Remove ${} from completion items' sortText #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adashen
reviewed
Nov 8, 2018
| @@ -100,6 +100,14 @@ export class ConfigCompletionItemProvider implements vscode.CompletionItemProvid | |||
| completionItem.range = overwriteRange; | |||
| completionItem.insertText = value + separator; | |||
| completionItem.kind = vscode.CompletionItemKind.Value; | |||
|
|
|||
| // Deprioritize image placeholders with platform (e.g., ${MODULES.SampleModule.amd64}) in completion item list | |||
There was a problem hiding this comment.
what I am thinking is not deprioritize, but the correct group together of names. Can we use the value without "${}" for sort?
There was a problem hiding this comment.
It's already grouped (master branch):
Do you mean we also need to remove platforms like amd64 from sortText?
There was a problem hiding this comment.
I mean sort the content in ${ }, MODULES.SampleFunction... Instead of the whole string ${MODULES.SampleFunction....} . use "split by ." is not robust. Since user may have folder name containing "."
LazarusX
changed the title
|
New order: |
adashen
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order with this change:
