Consider swapping sourcemap bias checking order

[roblourens]

IIRC, it's done this way because in some case the source-map lib will return mappings from a previous line, so if you set a breakpoint at line 5, col 0, you might get the mapping from line 4 instead.

[roblourens]

In node-debug, mapFromSource now does LEAST_UPPER_BOUND without falling back on the other one. MapToSource first does GREATEST_LOWER_BOUND, then falls back on least_upper if it doesn't find anything. I should do that too...

[auchenberg]

How does other editors and DevTools do this?
On Mon, Sep 26, 2016 at 10:16 PM Rob Lourens notifications@github.com
wrote:

In node-debug, mapFromSource now does LEAST_UPPER_BOUND without falling
back on the other one. MapToSource first does GREATEST_LOWER_BOUND, then
falls back on least_upper if it doesn't find anything. I should do that
too...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#112 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKl90LE0ZryuFPTk_ayjJjF8cOoLV1Cks5quKajgaJpZM4KHQx3
.

[roblourens]

It's hard to say since they are usually not using the source-map lib - they end up with the right mapping one way or another.

[roblourens]

For posterity, the main impact of this was Microsoft/vscode-chrome-debug#417

[nachocab]

@roblourens Regarding #19973, I can confirm that it is still not possible to set breakpoints on async/await code

[ermish]

+1 having same issue still

[roblourens]

Please open new issues