Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 2.0.0 #887

Merged
merged 5 commits into from Oct 19, 2018
Merged

Task 2.0.0 #887

merged 5 commits into from Oct 19, 2018

Conversation

torn4dom4n
Copy link
Contributor

"version": "2.0.0",
"task": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"task" should be "tasks"

"task": [
{
"label": "build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label needs to match the "preLaunchTask" in .vscode/launch.json. I would change those to "build".

Otherwise you see this when you start debugging:
screen shot 2018-10-19 at 10 06 54 am

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to "Compile". Is it OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with compile, but the important part is that it needs to match whatever the value for "preLaunchTask" is in .vscode\launch.json

https://github.com/Microsoft/vscode-cosmosdb/blob/master/.vscode/launch.json#L18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry! It is a mistake. I fixed it. Thanks.

"reveal": "never"
},
"args": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're updating the task, can you add:

"group": {
	"kind": "build",
	"isDefault": true
},

If you open up the command palette:
screen shot 2018-10-19 at 10 15 24 am

This designates this task as the build task to be run as a part of this:
screen shot 2018-10-19 at 10 14 43 am

@torn4dom4n
Copy link
Contributor Author

@EricJizbaMSFT can you review it again?

Copy link
Member

@ejizba ejizba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ejizba ejizba merged commit 28fa20e into microsoft:master Oct 19, 2018
@torn4dom4n torn4dom4n deleted the task-2 branch October 31, 2018 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants