This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Avoid duplicate function parameter body on function suggest snippets #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid adding snippet for function suggest when cursor is followed by (). Fixes microsoft#1655
ramya-rao-a
suggested changes
Jun 1, 2018
src/goSuggest.ts
Outdated
| let newSnippetString = null; | ||
| // Avoid adding snippet for function suggest when cursor is followed by () | ||
| // i.e: met() -> method()() | ||
| if ((nextSymbolIndex < lineText.length) && (lineText.charAt(nextSymbolIndex) === '(')) { |
There was a problem hiding this comment.
Why not check lineText.substr(position.character, 2) === '()' instead?
src/goSuggest.ts
Outdated
| // i.e: met() -> method()() | ||
| if ((nextSymbolIndex < lineText.length) && (lineText.charAt(nextSymbolIndex) === '(')) { | ||
| newSnippetString = new vscode.SnippetString(suggest.name); | ||
| } else { |
There was a problem hiding this comment.
Why not skip setting the item.insertText altogether if the cursor is followed by ()
There was a problem hiding this comment.
Because keeping the text insert will still autocomplete the function name sans the param snippets
ramya-rao-a
reviewed
Jun 3, 2018
src/goSuggest.ts
Outdated
| // Avoid adding snippet for function suggest when cursor is followed by () | ||
| // i.e: met() -> method()() | ||
| if (lineText.substr(position.character, 2) === '()') { | ||
| newSnippetString = new vscode.SnippetString(suggest.name); |
There was a problem hiding this comment.
We don't need to create a vscode.SnippetString in this case.
When item.insertText is not set, then item.label is used by the auto-completion feature.
See https://github.com/Microsoft/vscode/blob/1.23.0/src/vs/vscode.d.ts#L3047-L3052
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid adding snippet for function suggest when cursor is followed by (). Fixes #1655