This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
doc(README) Fix the revive flags examples. #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
approved these changes
Jun 1, 2018
There was a problem hiding this comment.
Thanks @wolfeidau!
I'll have to update the code to support resolving of ~, ${workspaceRoot} and ${workspaceFolder when the config file path is passed using -config flag.
Currently this is supported for the --config flag which is used by gometalinter
|
Added support to resolve the file path passed in the @wolfeidau Can you try using file paths that use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Road testing revive as a part of #1698 and found some small corrections required.