Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to register custom tag providers #3

Closed

Conversation

eamodio
Copy link

@eamodio eamodio commented Oct 23, 2016

This will hopefully allow other extensions to extend the html parsing with their own tags -- for example https://github.com/aurelia/vscode-extension

@eamodio eamodio force-pushed the feature-custom-tag-providers branch from d0a8ef2 to d76087e Compare October 24, 2016 14:06
@aeschli
Copy link
Contributor

aeschli commented Nov 23, 2016

The API makes sense, but note that in the case of VSCode the service is used on HTML language server that runs in its own process.
We have no mechanism yet on how to contribute to the server.

@eamodio
Copy link
Author

eamodio commented Nov 23, 2016

Ah - right. But at least this would allow other extensions to pull in this lib directly, rather than needing to re-implement.

@octref
Copy link
Contributor

octref commented Nov 29, 2018

@eamodio Would #41 work for you? You can read microsoft/vscode#62976 for more context.

@octref octref closed this Nov 29, 2018
@octref
Copy link
Contributor

octref commented Nov 29, 2018

Closing this as we probably won't go with this approach. JSON contributions make more sense. We'll likely introduce contributes.html.tags similar to how we allow markdown contributions: https://code.visualstudio.com/docs/extensionAPI/api-markdown.

@eamodio
Copy link
Author

eamodio commented Nov 29, 2018

@octref I think so, but honestly I can't really remember the full context as it was a long time ago. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants