Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis build for linux #980

Merged
merged 3 commits into from
Sep 13, 2017
Merged

Fix travis build for linux #980

merged 3 commits into from
Sep 13, 2017

Conversation

llali
Copy link
Member

@llali llali commented Sep 7, 2017

According to microsoft/vscode#33998
the fix was adding libsecret-1-dev as dependency

@kburtram
Copy link
Member

kburtram commented Sep 8, 2017

@llali could you check why the CI builds are failing on the PR before merging?

@llali
Copy link
Member Author

llali commented Sep 8, 2017

@karlb@microsoft.com
I'm not going to merge this. Well at least until I figure out if I have to change the version of vs code. The travis build for master if failing and I was trying changing the version of vs code in this PR to see if I can fix it

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7b8d619 on fix/linuxTests into ** on master**.

@llali llali changed the title using a lower version of vs code to see if the linux tests pass Fix travis build for linux Sep 12, 2017
@llali llali merged commit 935bdbd into master Sep 13, 2017
@kevcunnane kevcunnane deleted the fix/linuxTests branch September 19, 2017 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants