Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment ranges expand and allow adding comments to unsaved changes #186

Closed
RMacfarlane opened this issue Aug 14, 2018 · 2 comments
Closed

Comment ranges expand and allow adding comments to unsaved changes #186

RMacfarlane opened this issue Aug 14, 2018 · 2 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority upstream/vscode

Comments

@RMacfarlane
Copy link
Contributor

comment_range
@RMacfarlane RMacfarlane added bug Issue identified by VS Code Team member as probable bug upstream/vscode labels Aug 14, 2018
@rebornix rebornix self-assigned this Aug 14, 2018
@rebornix rebornix added the important Issue identified as high-priority label Aug 14, 2018
@RMacfarlane
Copy link
Contributor Author

With microsoft/vscode@22ab03e, the line decorations no longer move, but the new lines are still part of the commenting range. I think the correct behavior would be for the commenting range to actually get split in this case, which would be a more involved change

@rebornix rebornix added this to the August 2018 milestone Aug 23, 2018
@auchenberg auchenberg removed this from the August 2018 milestone Aug 30, 2018
@alexr00
Copy link
Member

alexr00 commented Dec 18, 2023

Not entirely sure what this issue is about. Closing, as it can't actually be important if it's been sitting around for 5 years.

@alexr00 alexr00 closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority upstream/vscode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@auchenberg @rebornix @RMacfarlane @alexr00