New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The GitHub Pull Request treeview never appears #395
Comments
@paulirish Thanks for reporting this. The Does the repository you have open have a remote that points to GitHub? |
Ah I see what's going on. These two lines should be filtering down the github remotes: However in my case the Promise.all() here rejects. And this is an uncaught rejection. ;) As a result, this just hangs indefinitely and never makes it past this line. Nor does it error. 😢Here's that error message:
That's pointing to https://github.com/Microsoft/vscode-pull-request-github/blob/5240b020c75f1e566e7e4a7aea6d67cc6412df65/src/authentication/githubServer.ts#L98 and (I have 27 remotes on this repo FWIW. :) Most are in this git:// form because of either my |
Nice fix, thank you! works well. BTW I do get hit with a Rate Limit error, but once i cleaned up my many remotes, dropping 27 to 2, it started playing nice again. :) |
Tried the extension from the marketplace and also building from source, but can't manage to get a treeview. No obvious errors I can spot, either.
Debugging it a bit, the extension does run all its startup methods:
https://github.com/Microsoft/vscode-pull-request-github/blob/44acd59147fb248577138b8ef3ee94eb6a5467d0/src/extension.ts#L45-L65
But despite that, no treeview is shown. Using insiders on everything, though I did try stable channel earlier to no avail.
only error in the logs i find is probably unrelated:
my git output:
and gh pr ext output:
is there any other debug info i can provide?
The text was updated successfully, but these errors were encountered: