Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting GitHub API rate limit clears received PR lists #465

Closed
davkal opened this issue Sep 13, 2018 · 3 comments
Closed

Hitting GitHub API rate limit clears received PR lists #465

davkal opened this issue Sep 13, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@davkal
Copy link

davkal commented Sep 13, 2018

  • Extension version: 0.1.4
  • VSCode Version: 1.27.1
  • OS: Mac

Steps to Reproduce:

  1. Open Code on a Grafana clone
  2. Expand Github Pull Requests (syncs fine, PR numbers show up)
  3. Expand All PRs list
  4. Click on a PR, and select some files.

Result:

  • a rate limit warning is displayed.
    screen shot 2018-09-13 at 13 41 23

  • the PR lists are cleared.

Expected:

  • keeping the lists
  • even better: a way to get around the rate limit
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Sep 13, 2018
@RMacfarlane
Copy link
Contributor

I just checked in a change that should make it much less likely for the API rate limit to be hit: 7a58197

Let me know if you're still seeing this in version 0.1.5 of the extension

@RMacfarlane RMacfarlane self-assigned this Sep 14, 2018
@davkal
Copy link
Author

davkal commented Sep 14, 2018

screen shot 2018-09-14 at 09 54 07

The lists are no longer cleared, but I still get the limit warning sometimes.
Feel free to close the issue unless you want to use it for the rate limit itself.

@rebornix
Copy link
Member

rebornix commented Jan 2, 2019

Same issue as #745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants