Notebook metadata being initialised in wrong place

[chrisjsewell]

Bug: Notebook Editor, Interactive Window, Editor cells

First noted in jupyter/jupyter-sphinx#108

Creating a new notebook with:

Name: Python
Id: ms-python.python
Description: Linting, Debugging (multi-threaded, remote), Intellisense, Jupyter Notebooks, code formatting, refactoring, unit tests, snippets, and more.
Version: 2020.2.64397
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-python.python 

leads to:

{
 "nbformat": 4,
 "nbformat_minor": 2,
 "metadata": {
  "language_info": {
    "name": "python",
    "codemirror_mode": {
      "name": "ipython",
      "version": 3
   }
  },
  "orig_nbformat": 2,
  "file_extension": ".py",
  "mimetype": "text/x-python",
  "name": "python",
  "npconvert_exporter": "python",
  "pygments_lexer": "ipython3",
  "version": 3
 },
 "cells": []
}

This is incorrect, because all the metadata should actually be under the language_info key:

{
 "nbformat": 4,
 "nbformat_minor": 2,
 "metadata": {
  "language_info": {
    "name": "python",
    "codemirror_mode": {
      "name": "ipython",
      "version": 3,
    },
    "orig_nbformat": 2,
    "file_extension": ".py",
    "mimetype": "text/x-python",
    "name": "python",
    "npconvert_exporter": "python",
    "pygments_lexer": "ipython3",
    "version": 3
  },
 },
 "cells": []
}

[DonJayamanne]

Thanks for filing this issue. I can confirm this is a bug at our end.

[chrisjsewell]

In a related matter, it would also be ideal if the notebook JSON was saved with sorted top-level keys, i.e. ['cells', 'metadata', 'nbformat', 'nbformat_minor']. This is to reduce git diffs, if for example I also open and save the notebook via jupyter notebook or jupyter lab (which save it in this manner).

[DonJayamanne]

In a related matter, it would also be ideal if the notebook JSON was save

Please could you file a separate issue for that.Thanks.
& I agree it will help with diffing..

[rchiodo]

Validated. Should be fixed in the next release

[chrisjsewell]

thanks 👍