Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New telemetry reporter "cleans" LSP methods in event properties #11597

Closed
jakebailey opened this issue May 5, 2020 · 1 comment
Closed

New telemetry reporter "cleans" LSP methods in event properties #11597

jakebailey opened this issue May 5, 2020 · 1 comment
Assignees
@kimadeline
Labels
area-diagnostics Logging/Features to facilitate diagnosing user problems bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Comments

@jakebailey
Copy link
Member

The new telemetry reporter in #11524 appears to be stripping non-paths in properties. Some events contain LSP methods, which can contain slashes, e.g. textDocument/completion. But they get sent as "<REDACTED: user-file-path>" instead.

A workaround might be to go change the LS to maybe send textDocument-completion or something that doesn't look like a path, but I think that the filtering is over-doing it. Perhaps there's a way to whitelist specific things.

Filing to not forget before a release.

@karthiknadig @kimadeline
@jakebailey jakebailey added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels May 5, 2020
@kimadeline kimadeline added area-diagnostics Logging/Features to facilitate diagnosing user problems needs PR important Issue identified as high-priority labels May 5, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label May 5, 2020
@kimadeline kimadeline self-assigned this May 5, 2020
@kimadeline kimadeline mentioned this issue May 5, 2020
Merged
10 tasks
@luabud luabud mentioned this issue May 5, 2020
Closed
@kimadeline kimadeline mentioned this issue May 14, 2020
Merged
10 tasks
@kimadeline
Copy link

Should be fixed now.

@ghost ghost removed the needs PR label May 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kimadeline kimadeline

Labels
area-diagnostics Logging/Features to facilitate diagnosing user problems bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakebailey @kimadeline