Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pylance in the repo #13007

Closed
kimadeline opened this issue Jul 16, 2020 · 6 comments
Closed

Use pylance in the repo #13007

kimadeline opened this issue Jul 16, 2020 · 6 comments
Assignees
@jasleen101010
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue

Comments

@kimadeline
Copy link

kimadeline commented Jul 16, 2020 •
edited
Loading

Have a default value that uses Pylance if installed, and otherwise falls back on Jedi.

The only change would be to switch "python.languageServer" to "Pylance" in .vscode/settings.json, but there are also a couple of things to check:

  • What happens if Pylance is not installed?
  • Can/should we move this setting to pvsc.code-workspace?
@kimadeline kimadeline added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team labels Jul 16, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jul 20, 2020
@luabud
Copy link
Member

luabud commented Aug 26, 2020

  • What happens if Pylance is not installed?

The Python extension prompts for you to install Pylance if the setting is set to it but the extension isn't installed.

  • Can/should we move this setting to pvsc.code-workspace?

Yes, let's do it!

@luabud luabud added the area-internal Label for non-user facing issues label Aug 26, 2020
@jasleen101010
Copy link

I would like to take up this issue for OSD 2021 if it's still available. Thanks :)

@luabud
Copy link
Member

luabud commented Jul 17, 2021

@jasleen101010 it is! Let us know if you want to give it a try, I think you still have 13 days to work on it for OSD right? 😊

@jasleen101010
Copy link

@luabud Yes, we can work on an issue and submit the form within 2 weeks. So, I would like to give this a try. Please assign it to me 😊

@luabud
Copy link
Member

luabud commented Jul 20, 2021

@jasleen101010 done! 😊

@jasleen101010 jasleen101010 mentioned this issue Jul 28, 2021
Merged
@jasleen101010
Copy link

@jasleen101010 done! 😊

Worked on this issue and opened a PR @luabud 😊I made my first open-source pull request, all thanks to you!

kimadeline added a commit that referenced this issue Jul 29, 2021
@jasleen101010 @kimadeline
Changed "python.languageServer" to "Pylance" as per Issue #13007 (#16804
c72e4fe 
)

* Changes "python.languageServer" to "Pylance"

* Update news/.vscode/settings.json

Changed "python.languageServer" to "Pylance"

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

* Updated CHANELOG with a new news entry

* Removed the changes done

Had added a manual entry which was removed as suggested.

* Changed "python.languageServer" to "Pylance"

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasleen101010 jasleen101010

Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@karthiknadig @jasleen101010 @luabud @kimadeline