Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LS on* handlers registered after they are called by the server #14893

Closed
jakebailey opened this issue Dec 4, 2020 · 0 comments
Closed

LS on* handlers registered after they are called by the server #14893

jakebailey opened this issue Dec 4, 2020 · 0 comments
Assignees
@jakebailey
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug

Comments

@jakebailey
Copy link
Member

Opening a bug I can close with a PR.

On working on a different LS fix, I found that in the LS proxies, their onNotification/onRequest/onTelemetry calls are done after the LS is ready, but not immediately after starting. This means that there's a window where the LS can be trying to send a message to the client before the handlers are registered, leading to missed notifications and/or incorrectly handled calls.
@jakebailey jakebailey added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Dec 4, 2020
@jakebailey jakebailey self-assigned this Dec 4, 2020
This was referenced Dec 4, 2020
Closed
Merged
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Dec 7, 2020
@brettcannon brettcannon added the area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. label Dec 7, 2020
@ghost ghost removed the needs PR label Jan 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakebailey jakebailey

Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @jakebailey