Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python extension sends 'ipynb' open/close/change events making it hard for pylance to be able to ignore these #18259

Closed
rchiodo opened this issue Jan 7, 2022 · 0 comments · Fixed by #18260
Closed

Python extension sends 'ipynb' open/close/change events making it hard for pylance to be able to ignore these #18259

rchiodo opened this issue Jan 7, 2022 · 0 comments · Fixed by #18260
Assignees
@rchiodo
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@rchiodo
Copy link

rchiodo commented Jan 7, 2022 •
edited
Loading

I need to update the middleware used by the python extension:
https://github.com/microsoft/vscode-jupyter-lsp-middleware/blob/main/src/node/hidingMiddlewareAddon.ts

So that it swallows notebook open/change/close events. Otherwise pylance will provide intellisense for these notebooks partially.
@rchiodo rchiodo added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Jan 7, 2022
@rchiodo rchiodo self-assigned this Jan 7, 2022
@rchiodo rchiodo added nb-golden and removed triage-needed Needs assignment to the proper sub-team labels Jan 7, 2022
This was referenced Jan 7, 2022
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rchiodo rchiodo

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide more notebook intellisense rchiodo/vscode-python
1 participant
@rchiodo