Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using conda to install Pylint #301

Closed
brettcannon opened this issue Nov 27, 2017 · 7 comments
Closed

Support using conda to install Pylint #301

brettcannon opened this issue Nov 27, 2017 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@brettcannon
Copy link
Member

We will probably want to auto-select the approach based on whether a conda install is selected for the interpreter or not.

@brettcannon brettcannon added awaiting 1-decision feature-request Request for new features or functionality labels Nov 27, 2017
@brettcannon brettcannon added this to the December 2017 milestone Nov 27, 2017
@DonJayamanne
Copy link

Scenario 1
Assume user has conda installed, and virtualenv named "X" is selected as the current env in vscode (assume this is not a conda environment).

Should we still allow the user to select conda as an option to install the module? I don't think so.
Solution - Check if the currently selected environment is a conda environment, and if it is, then allow user to select between conda and pip.

@brettcannon
Copy link
Member Author

Do we even need to let the user choose? Shouldn't we just use conda for a conda environment and pip for everything else?

@DonJayamanne
Copy link

Lol, agreed.

@DonJayamanne
Copy link

Not sure whether this is the right place to start this discussion, but here goes:
Do we need to consider looking into supporting pipenv or making that optional?

Came across a blog post the other day about that being the officially recommended packaging tool from python.

@brettcannon
Copy link
Member Author

I think they're referring to the fact that pipenv is recommended in the packaging.python.org docs. But considering the tool has an easter egg that compliments you for installing the author's other projects, I don't know how seriously we should take it yet.

Then again, people who use pipenv seem to like it and if we want to be on the cutting-edge then support wouldn't hurt. IOW I don't know. 😄

@garytyler
Copy link

garytyler commented Dec 11, 2017

I am not a fan of the easter egg @brettcannon mentions, but I'm working on a project that chose to use pipenv and it is a great workflow. I work on Windows, and the one issue I have come across is pipenv's lack of history buffer support in Windows cmd console: pew-org/pew#165. If I'm not mistaken, proper support in the Python plugin to direct calls to the pipenv interpreter through vscode would dodge some of the setbacks and make a significant positive impact on using pipenv in Windows, which is otherwise an unduly stunted workflow.

@brettcannon
Copy link
Member Author

I'm moving the discussion of pipenv over to #404.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants