Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten import regex #5988

Closed
brettcannon opened this issue Jun 12, 2019 · 0 comments
Closed

Tighten import regex #5988

brettcannon opened this issue Jun 12, 2019 · 0 comments
Assignees
@brettcannon
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
2019 - June Sprin...

Comments

@brettcannon
Copy link
Member

https://github.com/microsoft/vscode-python/blob/master/src/client/telemetry/importTracker.ts#L34 is a regex to match imports, but it can stand to be stricter.
@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Jun 12, 2019
@brettcannon brettcannon self-assigned this Jun 12, 2019
@brettcannon brettcannon mentioned this issue Jun 12, 2019
Merged
10 tasks
@brettcannon brettcannon added this to the 2019 - June Sprint 12 milestone Jun 13, 2019
@ghost ghost removed the needs PR label Jun 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brettcannon brettcannon

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
2019 - June Sprint 12
Development

No branches or pull requests
1 participant
@brettcannon