Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do best effort to download the experiments and use it in the very first session only #6348

Closed
karrtikr opened this issue Jun 26, 2019 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality

Comments

@karrtikr
Copy link

karrtikr commented Jun 26, 2019

Only for the first session, try downloading the experiments before activating the extension.

  • If the download completes under 2 seconds, we use the downloaded experiments for the first session.
  • If the download fails within 2 seconds, log error and use the existing experiments.json to get the experiments.
  • If the download does not complete within 2 seconds, fallback to what we were doing. That is, use the existing experiments.json to get the experiments.

Log telemetry for each of the 3 options. Activating the extension for the first time will take 2 more seconds as a consequence.

It will benefit us in case we want to change experiments mid-session, and want to make sure that the first session captures the new experiments. For instance,

In case of LS - enabled, for the users new to intellisense, we want to make sure the first experience (which could be the only experience) is Language server. Right now, what could happen is the first session will activate with Jedi, and LS will only be activated from the second session onwards.

@karrtikr karrtikr added feature-request Request for new features or functionality needs PR experimenting Feature is part of an experiment labels Jun 26, 2019
@karrtikr
Copy link
Author

cc/ @qubitron @luabud @brettcannon

@brettcannon brettcannon changed the title Do best effort to download the experiments and use it in the first session itself Do best effort to download the experiments and use it in the very first session only Jun 27, 2019
@brettcannon brettcannon removed the experimenting Feature is part of an experiment label Jun 27, 2019
@brettcannon brettcannon added this to the 2019 - June Sprint 13 milestone Jul 9, 2019
@karrtikr karrtikr self-assigned this Jul 11, 2019
@DonJayamanne DonJayamanne self-assigned this Jul 17, 2019
@ghost ghost removed the needs PR label Jul 29, 2019
@DonJayamanne DonJayamanne removed their assignment Jul 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants