Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ask how to install a linter when a non-conda interpreter is selected #969

Closed
brettcannon opened this issue Mar 6, 2018 · 2 comments · Fixed by #1065
Closed

Don't ask how to install a linter when a non-conda interpreter is selected #969

brettcannon opened this issue Mar 6, 2018 · 2 comments · Fixed by #1065
Assignees
@DonJayamanne
Labels
area-linting feature-request Request for new features or functionality
Milestone
March 2018

Comments

@brettcannon
Copy link
Member

The option to install using pip or conda is only relevant to conda which can support both. Otherwise you should just install using pip.
@brettcannon brettcannon added feature-request Request for new features or functionality area-linting needs PR labels Mar 6, 2018
@brettcannon brettcannon added this to the March 2018 milestone Mar 6, 2018
@brettcannon
Copy link
Member Author

Also lowercase the names of the tools in the menu options.

@DonJayamanne
Copy link

DonJayamanne commented Mar 7, 2018 •
edited
Loading

I thought the extension already did this. Guess something must have changed and I have not added unit tests for this.

I stand corrected, it never did this.

@DonJayamanne DonJayamanne mentioned this issue Mar 13, 2018
Merged
DonJayamanne added a commit that referenced this issue Mar 15, 2018
@DonJayamanne
Ensure conda installer is not used for non-conda environments (#1065)
05ad30e 
* 🐛 ensure conda install is not used for non conda environments
* ✅ add test
* 📝 change log
* Fixes #969
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
area-linting feature-request Request for new features or functionality
Projects
None yet
Milestone
March 2018
Development

Successfully merging a pull request may close this issue.

Ensure conda installer is not used for non-conda environments DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne