Add localization for Japanese #434
Conversation
|
Thank you for the PR, @YuichiNukiyama ! I have asked on Twitter for verification of your translation since no one on the team speaks Japanese. 😄 |
|
JA speaker here, had a look, LGTM with one question: why was Russian added in the README? Is this a relevant change? |
|
Thank you for your review. I remove ru from readme. |
package.nls.ja.json
Outdated
| "python.command.python.execSelectionInDjangoShell.title": "Django シェルで選択範囲/行を実行", | ||
| "python.command.jupyter.runSelectionLine.title": "選択範囲/行を実行", | ||
| "python.command.jupyter.execCurrentCell.title": "セルを実行", | ||
| "python.command.jupyter.execCurrentCellAndAdvance.title": "セルとアドバンスを実行", |
There was a problem hiding this comment.
Here "Advance" is a verb. Perhaps this line should be something like
"セルを実行して次へ".
package.nls.ja.json
Outdated
| @@ -0,0 +1,50 @@ | |||
| { | |||
| "python.command.python.sortImports.title": "Imports を並び替える", | |||
There was a problem hiding this comment.
"Import 文を並び替える" seems slightly better.
A plural form isn't common in Japanese.
package.nls.ja.json
Outdated
| { | ||
| "python.command.python.sortImports.title": "Imports を並び替える", | ||
| "python.command.python.startREPL.title": "REPL を開始", | ||
| "python.command.python.buildWorkspaceSymbols.title": "ワークスペース シンボルをビルド", |
There was a problem hiding this comment.
Maybe it's better to say "ワークスペースの" for adjective "Workspace".
package.nls.ja.json
Outdated
| "python.snippet.launch.attach.label": "Python: アタッチ", | ||
| "python.snippet.launch.attach.description": "リモートデバッグのためにデバッガをアタッチ", | ||
| "python.snippet.launch.scrapy.label": "Python: Scrapy", | ||
| "python.snippet.launch.scrapy.description": "統合ターミナル/コンソールで Scrapy" |
There was a problem hiding this comment.
No idea if "Scrapy" as a verb can be recognized by ordinary people
in Japan. Maybe it could be "Scrapy を実行" or "Scrapy る" ?
|
Thaks @yuja ! I follow your advice |
|
@brettcannon as this has been reviewed by two other individuals, I vote to merge this PR. Will merge later today. |
Basically it matches Japanese translation of vs code.