Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix len error in var exp #5421

Merged
merged 1 commit into from
Apr 23, 2019
Merged

fix len error in var exp #5421

merged 1 commit into from
Apr 23, 2019

Conversation

IanMatthewHuff
Copy link
Member

For #5420

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff merged commit 3febb03 into microsoft:master Apr 23, 2019
IanMatthewHuff added a commit that referenced this pull request Apr 23, 2019
@IanMatthewHuff
fix len error (#5421)
649433d
IanMatthewHuff added a commit that referenced this pull request Apr 23, 2019
@IanMatthewHuff
Merge pull request #5422 from Microsoft/dev/ianhu/releaseFixLenIssue
21d28f9 
fix len error (#5421)
DonJayamanne added a commit that referenced this pull request Apr 25, 2019
@DonJayamanne
Merge branch 'release' into mergeAprilRelease
fb1ac0d 
* release: (25 commits)
  Bump version
  remove unexpected trailing commas in JSON files (#5443)
  Fixes to creation of json for Language Server (#5436)
  Update version of Language Server
  Update version (#5435)
  Deprecate travis (#5434)
  Upload vsix to artifacts (#5412)
  Fix the flask app name prompt for launch config. (#5409)
  Reliably end test tasks in Azure Pipelines (#5410)
  fix len error (#5421)
  Fix null cases (#5419)
  Fix sorting of number only lists (#5416)
  add news
  cleanup and functional test
  working first draft
  Fix current cell colors again (#5403)
  Fix data viewer issues (#5405)
  Update 'news' command to directly update the changelog
  Fixes to the test explorer in displaying root (#5383)
  Include pylintrc (#5369)
  ...
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/noneInVarExp branch July 25, 2019 23:50
@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanMatthewHuff @rchiodo