Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging crashes under some conditions #367

Closed
weinand opened this issue Dec 16, 2016 · 4 comments
Closed

Debugging crashes under some conditions #367

weinand opened this issue Dec 16, 2016 · 4 comments

Comments

@weinand
Copy link

weinand commented Dec 16, 2016

From @vladimir-kotikov on November 17, 2016 14:12

We're using this extension in vscode-react-native to debug react-native code running inside separate Node process.

We've found that debuggee process sometimes just crashes after hitting some specific breakpoints with error message, that looks like it's coming somewhere from Node core.

#
# Fatal error in runtime\runtime-debug.cc, line 1423
# Check failed: args[0]->IsJSObject().
#

==== C stack trace ===============================

    v8::Testing::DeoptimizeAll [0x00007FF78E61D346+1835286]
    v8::Testing::DeoptimizeAll [0x00007FF78E7C9EFD+3591373]
    (No symbol) [0x000001C9699063AB]

After some investigation it appeared that the debuggee is actually stops on the breakpoint and reports this event to debugger but right after that, when the extesion tries to request stack, variables, one of these requests causes the crash.

The problem is 100% reproducible using the example at https://github.com/vladimir-kotikov/react_debug_mock/tree/node_v7_crash using the repro steps in README

Copied from original issue: microsoft/vscode-node-debug#112

@weinand
Copy link
Author

weinand commented Dec 16, 2016

@vladimir-kotikov this is related to Proxy objects: see microsoft/vscode#12749
Workaround: use the experimental node debugger node2.

@weinand
Copy link
Author

weinand commented Dec 16, 2016

From @gmramaswamy on December 16, 2016 11:30

@weinand Can you please help me understand where to specify this debugger "node2". i am using with vscode-react-native extension and in launch.json type is reactnative. please help.

@weinand
Copy link
Author

weinand commented Dec 16, 2016

@vladimir-kotikov aha, if your debug type is "reactnative" then you cannot switch to "node2" (and I will move this issue to the vscode-react-native extension).

@vladimir-kotikov
Copy link
Contributor

This issue has been fixed by switching to node2 debugging engine in #390. @MSLaguana, can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants