fix #59: when editing an exisiting project, add base starter if no dependencies are selected. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
commented
Apr 27, 2018
| @@ -61,7 +61,7 @@ export class DependencyManager { | |||
| } | |||
|
|
|||
| public getSelectedDependencies(): IDependency[] { | |||
| return this.selectedIds.map((id: string) => this.dict[id]); | |||
| return this.selectedIds.map((id: string) => this.dict[id]).filter(Boolean); | |||
Eskibear
commented
Apr 27, 2018
| @@ -26,7 +27,7 @@ export namespace dependencies { | |||
| const rawJSONString: string = await Utils.downloadFile(`${Utils.settings.getServiceUrl()}dependencies?bootVersion=${bootVersion}`, true, { Accept: "application/vnd.initializr.v2.1+json" }); | |||
| starters[bootVersion] = JSON.parse(rawJSONString); | |||
| } | |||
| return starters[bootVersion]; | |||
| return _.cloneDeep(starters[bootVersion]); | |||
There was a problem hiding this comment.
always return a copy, in case the caller modify the cached content.
Eskibear
commented
Apr 27, 2018
| @@ -186,8 +186,8 @@ export module Routines { | |||
| vscode.window.showInformationMessage("No changes."); | |||
| return; | |||
| } | |||
| const msgRemove: string = (toRemove && toRemove.length) ? `Removing: [${toRemove.map(d => manager.dict[d].name).join(", ")}].` : ""; | |||
| const msgAdd: string = (toAdd && toAdd.length) ? `Adding: [${toAdd.map(d => manager.dict[d].name).join(", ")}].` : ""; | |||
| const msgRemove: string = (toRemove && toRemove.length) ? `Removing: [${toRemove.map(d => manager.dict[d] && manager.dict[d].name).filter(Boolean).join(", ")}].` : ""; | |||
Eskibear
commented
Apr 27, 2018
| @@ -196,6 +196,14 @@ export module Routines { | |||
| TelemetryHelper.finishStep(stepProceed); | |||
| } | |||
|
|
|||
| // add spring-boot-starter if no selected starters | |||
There was a problem hiding this comment.
add default starter, same issue with spring-projects/sts4#52
|
The title can be edited to mention that this is about editing an existing project. start.spring.io will always give you the base starter if no dependencies are selected. |
Eskibear
changed the title
|
@snicoll changed as the suggestion. |
jdneo
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a project from Spring Initializr, it always gives you the base starter if no dependencies are selected.
So when we remove all the dependencies during editing, it should add the base starter back.