Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Allows naming which quick fixes should be run on save #231

Merged
merged 3 commits into from
Jul 24, 2017

Conversation

adenflorian
Copy link
Contributor

Implements #152 .

Feedback welcome 😄

@egamma
Copy link
Member

egamma commented Jul 24, 2017

@adenflorian thanks for the Pull Request. Looks good overall (you also changed the formatting rules which makes sense, since it adds minimal noise to the PR the formatting change is tolerable).

  • What is the reasoning behind the changes to the settings.json in tslint-server/.vscode/settings.json
  • You have added tslint/package-lock.json, which hints that you are using npm v5. Any things to consider when upgrading to npm v5?
  • Would be better if we could provide intellisense on the rule names and do some validation (but this is currently not support by the core vscode).

I'm currently in the middle of migrating the settings support of vscode-tslint for the new multi-root workspaces. This will take longer. I'll look into merging this PR before these changes before the other changes. So if there are delays you know why.

@egamma egamma merged commit 41750ce into microsoft:master Jul 24, 2017
egamma added a commit that referenced this pull request Jul 24, 2017
@egamma
Copy link
Member

egamma commented Jul 24, 2017

Decided to merge it in before the multi-root work. Published as 0.17.0, thanks again.

@adenflorian
Copy link
Contributor Author

@egamma

  • I added the formatting rules to the workspace settings so that my user settings wouldn't change the format of the whole document.

  • This was the first time I've seen the package-lock.json, so I'm new to the idea, but it seems to "optimize the installation process".

  • Agreed. I looked to see if any of the existing config for the extension did this, but it didn't seem to, so I decided to leave it for a separate enhancement/PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants