Tweaks to PR #231

tslint-server/src/server.ts

@@ -907,6 +907,7 @@ namespace AllFixesRequest {
 connection.onRequest(AllFixesRequest.type, (params) => {
 	let result: AllFixesResult = null;
 	let uri = params.textDocument.uri;
+	let isOnSave = params.isOnSave;
 	let documentFixes = codeFixActions[uri];
 	let documentVersion: number = -1;
 
@@ -923,8 +924,8 @@ connection.onRequest(AllFixesRequest.type, (params) => {
 		}
 	}
 
-	// Filter out fixes for problems that aren't set to be autofixable on save
-	if (params.isOnSave && Array.isArray(settings.tslint.autoFixOnSave)) {
+	// Filter out fixes for problems that aren't defined to be autofixable on save
+	if (isOnSave && Array.isArray(settings.tslint.autoFixOnSave)) {
 		const autoFixOnSave = settings.tslint.autoFixOnSave as Array<string>;
 		fixes = fixes.filter(fix => autoFixOnSave.indexOf(fix.problem.getRuleName()) > -1);
 	}

tslint-tests/.vscode/settings.json

@@ -1,9 +1,10 @@
 // Place your settings in this file to overwrite default and user settings.
 {
     "files.autoSave": "off",
-    "tslint.autoFixOnSave": [
-        "arrow-parens"
-    ],
+    // "tslint.autoFixOnSave": [
+    //     "arrow-parens"
+    // ],
+    "tslint.autoFixOnSave": false,
     // "tslint.nodePath": "c:\\tmp",
     "tslint.jsEnable": true
     // "tslint.trace.server": "verbose"

tslint-tests/debug.log

@@ -0,0 +1,2 @@
+[0724/103800.682:ERROR:tcp_listen_socket.cc(76)] Could not bind socket to 127.0.0.1:6010
+[0724/103800.693:ERROR:node_debugger.cc(87)] Cannot start debugger server

tslint-tests/tests/selective-auto-fix-on-save.ts

@@ -1,3 +1,6 @@
-let z = 'quotemark';
+// Only the 'arrow-parens' rule should be fixed, the 'quotemark' failure
+// should not be fixed
+//    "tslint.autoFixOnSave": ["arrow-parens"],
 
 [1, 2].map(num => console.log('test: ' + num));
+

tslint/CHANGELOG.md

@@ -1,3 +1,7 @@
+
+## 0.17.0
+- Added support to define which auto fixes should be applied automatically on save [#152](https://github.com/Microsoft/vscode-tslint/issues/152). 
+
 ## 0.16.0
 - Added quick fix to show the documentation of a rule.
 - Added description to the contributed variables `tslint4` and `tslint5`.