Skip to content

Commit

Permalink
Merge pull request #32826 from mazamachi/fix-composition-event
Browse files Browse the repository at this point in the history
Fix #32822. Stop propagation keydown event when keybinding.
  • Loading branch information
alexdima committed Sep 27, 2017
2 parents 1e90afa + d3245df commit e28fbfa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/vs/editor/browser/controller/textAreaInput.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export class TextAreaInput extends Disposable {
this._nextCommand = ReadFromTextArea.Type;

this._register(dom.addStandardDisposableListener(textArea.domNode, 'keydown', (e: IKeyboardEvent) => {
if (this._isDoingComposition && e.equals(KeyCode.KEY_IN_COMPOSITION)) {
if (this._isDoingComposition && e.keyCode === KeyCode.KEY_IN_COMPOSITION) {
// Stop propagation for keyDown events if the IME is processing key input
e.stopPropagation();
}
Expand Down

0 comments on commit e28fbfa

Please sign in to comment.