Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll is gone after exiting vi in integrated terminal #11244

Closed
rebornix opened this issue Aug 30, 2016 · 4 comments
Closed

Scroll is gone after exiting vi in integrated terminal #11244

rebornix opened this issue Aug 30, 2016 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
September 2016

Comments

@rebornix
Copy link
Member

rebornix commented Aug 30, 2016 •
edited
Loading

Testing #11134

  • VSCode Version: 1.5.0-Insiders
  • OS Version: Ubuntu 14.04

Steps to Reproduce:

  1. Open integrated terminal
  2. Run vi
  3. Quit vi
  4. The scrollbar is missing and the pane is not scrollable any more. If you press <enter> again, the scrollbar is back.
@rebornix
Copy link
Member Author

FYI, this issue doesn't happen when using nano.

@Tyriar
Copy link
Member

Tyriar commented Aug 31, 2016

I believe I fixed this upstream already so I need to do an uplevel.

@Tyriar Tyriar added the terminal Integrated terminal issues label Aug 31, 2016
@Tyriar
Copy link
Member

Tyriar commented Aug 31, 2016

Upstream issue: xtermjs/xterm.js#242

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 31, 2016
@Tyriar Tyriar modified the milestones: August 2016, September 2016 Aug 31, 2016
@Tyriar
Copy link
Member

Tyriar commented Aug 31, 2016

Due to the recent xterm.js module refactor this is too high risk for August.

@Tyriar Tyriar mentioned this issue Aug 31, 2016
Closed
@Tyriar Tyriar closed this as completed in 179f86f Sep 16, 2016
@Tyriar Tyriar added the verified Verification succeeded label Sep 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
2 participants
@rebornix @Tyriar