Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll stops working after running vim #242

Closed
rgl opened this issue Aug 22, 2016 · 3 comments
Closed

Scroll stops working after running vim #242

rgl opened this issue Aug 22, 2016 · 3 comments
Assignees
Labels
type/bug Something is misbehaving

Comments

@rgl
Copy link

rgl commented Aug 22, 2016

Details

  • Browser and browser version: Chrome 52.0.2743.116 (64-bit)
  • OS version: OSX 10.11.6
  • xterm.js version: master (01c2080) I guess its 1.1.2.

Steps to reproduce

  1. Make sure there is scrollable content on the terminal (e.g. run dmesg).
  2. Make sure you can scroll the text using normal mouse wheel scrolling.
  3. Start and quit vim.
  4. Realize you no longer can scroll the text (it can scroll again if you press the ENTER key).
@Tyriar
Copy link
Member

Tyriar commented Aug 22, 2016

Did you actually repro this in master? Something similar was meant to be fixed in 588d3b1

@rgl
Copy link
Author

rgl commented Aug 23, 2016

Yes, I did (as you can see from the revision I've linked). But that fix seems to be disabling scrolling when in application mode. What I'm reporting is that scrolling is not re-enabled after exiting that mode.

So, maybe this is happening because isApplicationMode is being set when entering the application mode, but its not unset when leaving it?

@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2016

Put out a PR that I think should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants