Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to show icons in more places (tabs, open editors, quick open) #11751

Closed
ivancuric opened this issue Sep 9, 2016 · 15 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues

Comments

@ivancuric
Copy link

  • VSCode Version: 1.51

It would be great if VScode supported an option to show the icons in open tabs and editors.

@ivancuric ivancuric changed the title Option to enable icons in tabs / open editors [feature] Option to enable icons in tabs / open editors Sep 9, 2016
@ramya-rao-a ramya-rao-a added the workbench-tabs VS Code editor tab issues label Sep 9, 2016
@ramya-rao-a
Copy link
Contributor

The release notes does talk about eventually supporting icons for tabs.

"Open editors" here refer to the opened editors as opposed to open editors section on the side bar in #11287

@bpasero bpasero changed the title [feature] Option to enable icons in tabs / open editors Option to enable icons in tabs / open editors Sep 9, 2016
@bpasero bpasero added the feature-request Request for new features or functionality label Sep 9, 2016
@bpasero bpasero added this to the September 2016 milestone Sep 9, 2016
@bpasero bpasero changed the title Option to enable icons in tabs / open editors Option to enable icons in tabs / open editors / quick open Sep 12, 2016
@bpasero bpasero changed the title Option to enable icons in tabs / open editors / quick open Support to show icons in more places (tabs, open editors, quick open) Sep 20, 2016
@bpasero
Copy link
Member

bpasero commented Sep 21, 2016

Icons are now showing in these additional locations once you pick an icon theme:

  • open editors view
  • tabs
  • title in editor when tabs are disabled
  • search results
  • problems
  • quick open / editor pickers

@infinnie
Copy link
Contributor

I wish we were able to configure its behavior on where icons can show up.

@bpasero
Copy link
Member

bpasero commented Sep 26, 2016

@infinnie where do you want to not see icons?

@infinnie
Copy link
Contributor

@bpasero wherever it seems too visually cluttered.

@bpasero
Copy link
Member

bpasero commented Sep 26, 2016

@infinnie like?

@joshsleeper
Copy link

@bpasero I think what @infinnie is trying to say is that it'd be nice to be able to turn the icons on or off in each location based on one or more config entries.

That is, if I run a small screen with a lot of tabs for example, maybe I'm not keen on showing the icons on the tabs themselves.

I'm not sure how hard that would be to add support for a config entry per-icon-location (or maybe just one config entry that takes an array/dict/etc.), but I believe that's what he's suggesting.

@infinnie
Copy link
Contributor

@joshsleeper BTW I am female. What a pity it is for GitHub not to be able to let us config and display our sexes (or genders?)

@joshsleeper
Copy link

@infinnie And I've been trying so hard to be more gender neutral with my comments too! Bah on me, super sorry about that, I promise it wasn't ill intended.

@bpasero
Copy link
Member

bpasero commented Sep 29, 2016

@joshsleeper for that reason there is a setting to disable icons in tabs. that is the only setting we provide for now. I am still trying to find out where else @infinnie would want to configure this.

@infinnie
Copy link
Contributor

@bpasero That would be fine!

@bpasero
Copy link
Member

bpasero commented Sep 29, 2016

Ok then it looks like we are good.

@jtlowe
Copy link

jtlowe commented Oct 14, 2016

Glad to see this setting! It wasn't immediately clear to me what the setting ".showIcons" actually did, even after reading the comment above it. Maybe "workbench.editor.showTabIcons" would be better.

@bpasero
Copy link
Member

bpasero commented Oct 14, 2016

@jtlowe no, the icons also show up when tabs are disabled

@jtlowe
Copy link

jtlowe commented Oct 14, 2016

@bpasero I see what you're saying. My last thought would be something like: "Controls if opened editors should show with an icon next to their title or not." I don't know if this would have helped me initially though. I need to improve on my vscode terminology. Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

7 participants