Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: comments inside a script tag no longer sensitive to script language #12969

Closed
bgashler1 opened this issue Sep 29, 2016 · 3 comments
Closed

HTML: comments inside a script tag no longer sensitive to script language #12969

bgashler1 opened this issue Sep 29, 2016 · 3 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) html HTML support issues
Milestone
Backlog

Comments

@bgashler1
Copy link
Contributor

bgashler1 commented Sep 29, 2016 •
edited
Loading

  • VSCode Version: Insiders
  • OS Version: Windows 10

Regarding test plan item #12100

Steps to Reproduce:

  1. Select some JavaScript code inside of a <script> block in an HTML file*.
  2. Use the keyboard shortcut to "Add a line comment" or run the command from the command palette.
  3. Note that in the latest Insiders build, it no longer uses //``JavaScript-valid comments; instead, it now uses` comments.

Current Insiders
screen shot 2016-09-28 at 9 44 55 pm

Current Stable
screen shot 2016-09-28 at 9 44 18 pm

*I'm not sure, but this may apply to Handlebars and Razor also.
@bgashler1 bgashler1 added the bug Issue identified by VS Code Team member as probable bug label Sep 29, 2016
@bgashler1 bgashler1 added this to the September 2016 milestone Sep 29, 2016
@egamma egamma modified the milestones: October 2016, September 2016 Sep 30, 2016
@egamma
Copy link
Member

egamma commented Sep 30, 2016

HTML has been extracted into a separate language server and this functionality has been lost. Moving to October.

We should document this limitation in the release notes.

@sandy081 sandy081 added the html HTML support issues label Sep 30, 2016
@sandy081 sandy081 removed their assignment Sep 30, 2016
@felixfbecker
Copy link
Contributor

#1751?

@mrmlnc mrmlnc mentioned this issue Oct 11, 2016
Closed
@aeschli aeschli added the debt Code quality issues label Oct 11, 2016
@aeschli
Copy link
Contributor

aeschli commented Oct 11, 2016

duplicate of #11081

@aeschli aeschli closed this as completed Oct 11, 2016
@aeschli aeschli modified the milestones: Backlog, October 2016 Oct 11, 2016
@mrmlnc mrmlnc mentioned this issue Oct 15, 2016
Closed
@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 27, 2016
@Astray-git Astray-git mentioned this issue Nov 24, 2016
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) html HTML support issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@egamma @roblourens @aeschli @felixfbecker @sandy081 @bgashler1