Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: comments inside a script tag no longer sensitive to script language #12969

Closed
bgashler1 opened this issue Sep 29, 2016 · 3 comments
Closed

HTML: comments inside a script tag no longer sensitive to script language #12969

bgashler1 opened this issue Sep 29, 2016 · 3 comments
Assignees
Milestone

Comments

@bgashler1
Copy link
Contributor

@bgashler1 bgashler1 commented Sep 29, 2016

  • VSCode Version: Insiders
  • OS Version: Windows 10

Regarding test plan item #12100

Steps to Reproduce:

  1. Select some JavaScript code inside of a <script> block in an HTML file*.
  2. Use the keyboard shortcut to "Add a line comment" or run the command from the command palette.
  3. Note that in the latest Insiders build, it no longer uses //``JavaScript-valid comments; instead, it now uses` comments.

Current Insiders
screen shot 2016-09-28 at 9 44 55 pm

Current Stable
screen shot 2016-09-28 at 9 44 18 pm

*I'm not sure, but this may apply to Handlebars and Razor also.

@egamma

This comment has been minimized.

Copy link
Member

@egamma egamma commented Sep 30, 2016

HTML has been extracted into a separate language server and this functionality has been lost. Moving to October.

We should document this limitation in the release notes.

@sandy081 sandy081 added the html label Sep 30, 2016
@sandy081 sandy081 removed their assignment Sep 30, 2016
@felixfbecker

This comment has been minimized.

Copy link
Contributor

@felixfbecker felixfbecker commented Oct 1, 2016

@aeschli

This comment has been minimized.

Copy link
Contributor

@aeschli aeschli commented Oct 11, 2016

duplicate of #11081

@aeschli aeschli closed this Oct 11, 2016
@aeschli aeschli modified the milestones: Backlog, October 2016 Oct 11, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.