Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embedded modes for TextMate grammars #11081

Closed
aeschli opened this issue Aug 29, 2016 · 3 comments
Closed

Support embedded modes for TextMate grammars #11081

aeschli opened this issue Aug 29, 2016 · 3 comments
Assignees
@alexdima @aeschli
Labels
debt Code quality issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2016

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 29, 2016

With TextMate grammars we no longer support embedded modes which control the behaviour of smart editing (brackets, comments).

Text mate scopes can be used for that, but we should fix the flattening of scopes first (#3008)
@aeschli aeschli added the debt Code quality issues label Aug 29, 2016
@aeschli aeschli added this to the Backlog milestone Aug 29, 2016
This was referenced Aug 29, 2016
Closed
Closed
This was referenced Oct 11, 2016
Closed
Closed
@aeschli aeschli modified the milestones: October 2016, Backlog Oct 11, 2016
@aeschli aeschli mentioned this issue Oct 13, 2016
Closed
This was referenced Oct 14, 2016
Closed
Closed
Closed
This was referenced Oct 17, 2016
Closed
Closed
This was referenced Oct 17, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 24, 2016
Closed
Closed
@alexdima alexdima added the verification-needed Verification of issue is requested label Oct 24, 2016
@alexdima
Copy link
Member

alexdima commented Oct 24, 2016 •
edited
Loading

IMHO each and every one of the linked issues needs to be verified independently, as the generation of mode transitions from TM tokens depends heavily on the TM grammar (i.e. if the grammar does not use top-level scope names in the embedded portions, the mode transitions auto-generation will not work).

It works however for HTML, which uses source.css.embedded.html for embedded css, etc.

The relevant plan item is #14136

comment-line

@octref octref added the verified Verification succeeded label Oct 26, 2016
This was referenced Oct 26, 2016
Closed
Closed
@chjtx
Copy link

chjtx commented Oct 31, 2016

I hate TextMate, and how can I remove it?

@wxs77577
Copy link

still not work, how to fix?

@KamasamaK KamasamaK mentioned this issue Oct 6, 2017
Open
@vazexqi vazexqi mentioned this issue Oct 31, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

@aeschli aeschli

Labels
debt Code quality issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2016
Development

No branches or pull requests
5 participants
@wxs77577 @octref @alexdima @aeschli @chjtx