The sidebar is throwing errors like crazy in VSCode 1.6.0

[JamesMessinger]

This behavior started happening after upgrading to VSCode 1.6.0 today.

• VSCode Version: Code 1.6.0 (e52fb0b, 2016-10-10T18:28:55.412Z)
• OS Version: Darwin x64 16.0.0
• Extensions: QassimFarid.ejs-language-support-0.0.1, dbaeumer.vscode-eslint-1.0.7, donjayamanne.githistory-0.1.0, naumovs.node-modules-resolve-1.0.2, nwallace.peep-0.0.5

Steps to Reproduce:

1. Search pane is blank

1. Launch Visual Studio Code
2. Click the magnifying glass on the left side to switch to the "Search" pane
3. The search pane is empty. No search fields (see screenshot)
   

2. Cannot read property 'focus' of undefined

1. Launch Visual Studio Code
2. Press cmd+shift+f to trigger the workbench.view.search command
3. An error occurs (see screenshot)
   

3. Cannot read property 'toCustomLabel' of undefined

1. Launch Visual Studio Code
2. Press cmd+shift+f to trigger the workbench.view.search command
3. An error occurs (see screenshot)
   

4. Cannot read property 'setWidth' of undefined

1. Launch Visual Studio Code
2. Press cmd+b to trigger the workbench.action.toggleSidebarVisibility command
3. An error occurs (see screenshot)
   

[JamesMessinger]

Here are the error messages in the devtools console....

[JamesMessinger]

btw... these errors happen even with the --disable-extensions argument, so they don't appear to be caused by an extension

[chrmarti]

Does code --force-gpu-rasterization help any?

[TimMensch]

Just ran into this myself with 1.6. With --force-gpu-rasterization I get:

Cannot read property 'toCustomLabel' of undefined

[JamesMessinger]

@chrmarti - I tried code --force-gpu-rasterization and code --force-gpu-rasterization --disable-extensions. Neither one fixed the problem :(

[chrmarti]

Possibly related to #12709

[TimMensch]

I at least do not have the REST Client extension installed, and --disable-extensions doesn't fix the issue.

[chrmarti]

@TimMensch Which OS and OS version are you running?

[TimMensch]

Windows 10/x64, version 1.6.0, 2016-10-10T18:37:40

[TimMensch]

Sorry, OS version: Windows 10 Pro, 1511, 10586.589

[TimMensch]

@chrmarti I've got another Windows 10 system, but I've not let VS Code update on it for fear of losing search on both.

[JamesMessinger]

I uninstalled all of my extensions, just to see if that helped, but no luck.

[chrmarti]

Could you append your keybindings.json? There appears to be a bug with the new commands in the Search viewlet. @sandy081

[TimMensch]

I'm not modifying the "Find" key:

[
    { "key": "ctrl+]", "command": "editor.action.jumpToBracket", "when": "editorTextFocus" },
    { "key": "ctrl+alt+b", "command": "editor.action.format","when": "editorTextFocus" },
    { "key": "ctrl+w", "command": "workbench.action.closeActiveEditor" },
    { "key": "alt+w","command": "expand_region" },
    { "key": "alt+left",         "command": "workbench.action.focusPreviousGroup" },
    { "key": "alt+right",        "command": "workbench.action.focusNextGroup" },
    { "key": "ctrl+'", "command": "esQuotes.transformBetweenSingleDoubleQuotes" },
    { "key": "ctrl+alt+left",         "command": "workbench.action.focusPreviousGroup" },
    { "key": "ctrl+alt+right",        "command": "workbench.action.focusNextGroup" },
    { "key": "ctrl+shift+'", "command": "esQuotes.transformToTemplateString" },
    { "key": "ctrl+alt+d ctrl+alt+t", "command":"docthis.traceTypeScriptSyntaxNode"}
]

[TimMensch]

@chrmarti For fun I deleted my keybindings and it still comes up with the same error, and selecting View: Show Search from the command palette also brings up the same error.

[JamesMessinger]

@chrmarti - Yep. I was just about to post that.

I completely uninstalled VSCode and deleted my ~/Library/Application Support/Code folder. Then I reinstalled VSCode, and the errors were gone. 👍

Then I restored my custom keybindings and restarted VSCode, and the errors were back. 👎

So I started removing custom keybindings one-by-one and restarting VSCode after each one until I found the culprit. Here is the keybinding that's causing the error (for me, anyway)...

// Place your key bindings in this file to overwrite the defaults
[
  {
    "key": "alt+cmd+w",
    "command": "workbench.action.closeAllEditors"
  }
]

[TimMensch]

@BigstickCarpet @chrmarti Sure enough, success:

    { "key": "alt+w","command": "expand_region" },

This was the culprit for me. It didn't fix things to just delete it; I had to restart VS Code between tests.

[chrmarti]

A workaround would be to make sure the following commands are bound to at least one (arbitrary) key combination:

• "toggleSearchCaseSensitive"
• "toggleSearchWholeWord"
• "toggleSearchRegex"

And, as you mentioned, a restart is necessary to make it work.

[TimMensch]

Awesome sleuthing. 🕵️ This also works for me:

    { "key": "alt+w","command": "expand_region", "when":"editorFocus" },

I added a "when" clause to my keybinding so it wouldn't kill the other binding, just hide it when the editor is active.

[chrmarti]

/cc @isidorn

[carmanchris31]

Problem for me was also a custom keybinding:
{ "key": "cmd+alt+r", "command": "workbench.action.focusSideBar" },

Presumably because it overwrites the default for toggleFindRegex and thus invalidates the requirements specified by @chrmarti :
{ "key": "alt+cmd+r", "command": "toggleFindRegex", "when": "editorFocus" },

[eduardonunesp]

To me it only happens when assigns to cmd+alt+r, for instance:

left menu empty

  {
    "key": "cmd+alt+r",
    "command": "editor.action.format"
  }

left menu ok

  {
    "key": "cmd+r",
    "command": "editor.action.format"
  }

[sandy081]

@eduardonunesp On Mac, cmd+alt+r is the short cut for enabling reg-ex toggleSearchCaseSensitive in Search view which is taken by editor.action.format. I have fix in ready and is already available in Insiders. Temporary workaround is to assign a different shortcut for toggleSearchCaseSensitive.

Thanks

[OliverJAsh]

Problem for me was due to:

{ "key": "alt+cmd+c", "command": "workbench.files.action.collapseFilesExplorerFolders" }

[d4v1dst]

Same here on MacOS El Capitan

my keybindings.json was

[
    { "key": "shift+cmd+7",                 "command": "editor.action.commentLine"},
    { "key": "alt+`",                 "command": "workbench.action.navigateBack" },
    { "key": "shift+alt+`",                 "command": "workbench.action.navigateForward" },
    { "key": "cmd+alt+c",           "command": "workbench.action.git.input-commit" },
    { "key": "cmd+alt+p",           "command": "workbench.action.git.push" },
    { "key": "cmd+m",          "command": "editor.action.jumpToBracket"}
]

After delete the custom keybindings and restart, everything works fine.

[sandy081]

@d4v1dst Sorry for that. This is because of the key-binding cmd+alt+c.

[sandy081]

Verification:

Customize following default key bindings to other actions

Mac

• alt+cmd+c
• alt+cmdr
• alt+cmdw

Windows/Linux

• alt+c
• alt+r
• alt+w

Verify that Search view is opening without any errors

[bogdan-d]

For me, these custom keybindings were the issue, after removing them, the search view worked:

{ "key": "shift+alt+c", "command": "toggleFindCaseSensitive", "when": "editorFocus" },
{ "key": "shift+alt+w", "command": "toggleFindWholeWord", "when": "editorFocus" },

Also, I need to mention that I have another custom key bound to alt+c, that before the update of vs code to 1.6.0, was a free key:
{ "key": "alt+c", "command": "vstortoise.svnCommit" },

[sandy081]

@lypscan alt+c was always taken to toggle case sensitive option in Editor find widget. With your customization, this key binding was overridden

[bogdan-d]

@sandy081 yes, now I remember... In any case, the error seems to manifest itself whenever I override the default keybindings for: toggleFindCaseSensitive, toggleFindWholeWord, toggleFindRegex.