Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow debug adapters to customize the behavior of the 'restart' button #14189

Closed
roblourens opened this issue Oct 21, 2016 · 7 comments
Closed
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Oct 21, 2016

For the chrome debugging extension, it would be much more useful if the debug 'restart' button/action could refresh the page. This could be implemented by the debug adapter. For other cases, the current behavior should be kept where vscode shuts down/restarts the debug adapter. Is this generic enough to be part of the debug protocol?

@roblourens roblourens added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Oct 21, 2016
@weinand weinand added this to the November 2016 milestone Oct 21, 2016
@weinand
Copy link
Contributor

weinand commented Oct 21, 2016

@roblourens yes, that makes a lot of sense (and we were discussing this use case already when implementing the current 'restart' functionality).
I'll come up with a proposal.

@weinand
Copy link
Contributor

weinand commented Nov 10, 2016

I've added a restart request to the protocol and a corresponding supportsRestartRequest capability.

@isidorn please adopt this by calling the restart request if supportsRestartRequest is true (and skip the default implementation that terminates the adapter and launches it anew).

@weinand
Copy link
Contributor

weinand commented Nov 14, 2016

@roblourens please adopt this feature in the Debugger for Chrome.

@isidorn isidorn added the verification-needed Verification of issue is requested label Dec 6, 2016
@sandy081
Copy link
Member

sandy081 commented Dec 8, 2016

Verified by using Chrome debug extension for VS Code. Restarting refreshes VS Code

@sandy081 sandy081 added verified Verification succeeded and removed verified Verification succeeded labels Dec 8, 2016
@sandy081
Copy link
Member

sandy081 commented Dec 8, 2016

I am not sure if above comment is the right way of verification, hence removing the verified tag. If you can let me know the right way I can verify it.

@weinand
Copy link
Contributor

weinand commented Dec 8, 2016

@roblourens did you surface this new feature in the 'Debugger for Chrome'?
If not it will be difficult to verify it.

@roblourens
Copy link
Member Author

Yes, that's correct @sandy081

@roblourens roblourens added the verified Verification succeeded label Dec 8, 2016
@egamma egamma mentioned this issue Dec 20, 2016
56 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants