Recommend changing ignoreTrimWhitespace default to false

[pbrianmackey]

I recommend modifying VS code to default to diffEditor.ignoreTrimWhitespace = false to maintain parity with git diff. On my team whitespace is a big part of the code review and beautification process. Not being able to see the whitespace in a diff lead me down a rabbit hole. That's not a good place to be for a new user.

More details on my initial experiences with this: http://stackoverflow.com/questions/30140595/show-whitespace-characters-in-visual-studio-code/40744352#40744352

[chrisdias]

@pbrianmackey sorry about the settings confusion, we're working on this see here.

Assigning to @alexandrudima for default setting question...

[alexdima]

Most diff editors show a prominent toggle in the form of an icon that switches between ignoring trim whitespace or not. IMHO, we need to add such a UI element.

[AmeliaBR]

+1 to an "ignore whitespace" toggle in the interface.

This issue has become even more important with the new partial-staging feature, where you can stage and commit individual changes from the editor.

Currently, if you make a change that also affects whitespace of other lines (like adding a try block around code, then indenting the code inside the block without changing it), the indentation change doesn't get included if you stage the new lines. There isn't currently any way to include it other than changing your configs (or committing the entire file).

[iamdevlinph]

As of

Version: 1.26.1
Commit: 493869ee8e8a846b0855873886fc79d480d342de
Date: 2018-08-16T18:38:57.434Z
Electron: 2.0.5
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

The setting "diffEditor.ignoreTrimWhitespace" is still default to true.

[alexdima]

We have a prominent action in the diff editor to toggle the diff algorithm to ignore trim whitespace or not.

There are no plans to change the default.

[vscodebot]

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!