Some editor settings are not being respected by language #19511

Closed
sandy081 opened this Issue Jan 27, 2017 · 5 comments

Projects

None yet

3 participants

@sandy081
Member

Following settings are not getting update by language

editor.tabSize
editor.insertSpaces
editor.detectIndentation
editor.trimAutoWhitespace
@sandy081 sandy081 self-assigned this Jan 27, 2017
@sandy081 sandy081 added this to the January 2017 milestone Jan 27, 2017
@sandy081
Member

Above settings comes from the Model and are created/updated by the modelService. Fixing this need adoption in modelService to language based changes to configurations.

@sandy081 sandy081 added the candidate label Jan 27, 2017
@sandy081 sandy081 added a commit that referenced this issue Jan 30, 2017
@sandy081 sandy081 #19511 Clean up f7c7b55
@sandy081 sandy081 added a commit that referenced this issue Jan 30, 2017
@sandy081 sandy081 #19511 Fix compilation issues 131a39f
@sandy081 sandy081 added a commit that referenced this issue Jan 30, 2017
@sandy081 sandy081 #19511 Model Builder returns RawTextProvider instead of RawText
 - model creation options can now be specified at a later stage
25af6cd
@sandy081 sandy081 added a commit that referenced this issue Jan 30, 2017
@sandy081 sandy081 #19511 Model Builder returns RawTextProvider instead of RawText
 - model creation options can now be specified at a later stage
46777f6
@sandy081 sandy081 added a commit that referenced this issue Jan 30, 2017
@sandy081 sandy081 #19511 Model Builder returns RawTextProvider instead of RawText
 - model creation options can now be specified at a later stage
66fe014
@sandy081 sandy081 closed this Jan 30, 2017
@bpasero bpasero added the verified label Jan 31, 2017
@sandy081 sandy081 modified the milestone: February 2017, January 2017 Jan 31, 2017
@sandy081
Member
sandy081 commented Jan 31, 2017 edited

We decided to revert this fix from 1.9 release because, Current code is not ready to provide a simple fix for this. This needs quiet amount of refactoring

  • Model service has to be adopted to language based settings
  • Model builder and its callers has to be refactored and adopted to language based settings. Core of the problem is that Model builder consumes config options to create IRawText which is an input for creating a Model. Since, config options are independent of language there were no issues. But from now, they are dependent on language. To get language we either need file URI and file first line. First line is not available until Model Builder builds IRawText. So it is a chicken-egg problem which needs proper split of IRawText to IConfigurationUnawareRawText. And, Model builder spits this new IConfigurationUnawareRawText and the Model Service can create the model from this IConfigurationUnawareRawText and the language.

This from an implementation perspective a feature by itself and is risky to implement this at the very end of 1.9. Hence we decided to revert this fix and make this available in February release.

So long story short, in 1.9 release, users cannot configure above described settings by language. This will be available in latest insiders and from next stable release.

@sandy081 sandy081 reopened this Jan 31, 2017
@sandy081 sandy081 removed the verified label Jan 31, 2017
@sandy081 sandy081 added a commit that referenced this issue Jan 31, 2017
@sandy081 sandy081 #19511 Define and use ITextSource2
- Wraps processed information from file
- Helper methods in TextModel to create RawText
9c56607
@sandy081 sandy081 removed the candidate label Jan 31, 2017
@sandy081 sandy081 closed this Jan 31, 2017
@mdalpi
mdalpi commented Feb 6, 2017

Maybe files.exclude should be added to the list, I'm getting "Unknown identifier. Use language identifiers" trying to set under Python settings.

@sandy081
Member
sandy081 commented Feb 6, 2017

@mdalpi Please let me know the use case behind supporting files.exclude in the list? Also please create a separate issue for that. Thanks.

@mdalpi
mdalpi commented Feb 6, 2017

@sandy081 I'll use just to ignore cache files (*.pyc files and __pycache__ folder specifically). Of course I can do with the global setting just fine, I just thought that this would be possible. We should wait for others to create an issue about this (maybe I'm the only trying this particular case). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment