-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some editor settings are not being respected by language #19511
Comments
Above settings comes from the Model and are created/updated by the modelService. Fixing this need adoption in modelService to language based changes to configurations. |
- model creation options can now be specified at a later stage
- model creation options can now be specified at a later stage
- model creation options can now be specified at a later stage
We decided to revert this fix from 1.9 release because, Current code is not ready to provide a simple fix for this. This needs quiet amount of refactoring
This from an implementation perspective a feature by itself and is risky to implement this at the very end of 1.9. Hence we decided to revert this fix and make this available in February release. So long story short, in 1.9 release, users cannot configure above described settings by language. This will be available in latest insiders and from next stable release. |
- Wraps processed information from file - Helper methods in TextModel to create RawText
Maybe |
@mdalpi Please let me know the use case behind supporting |
@sandy081 I'll use just to ignore cache files ( |
I'm currently unable to avoid auto-save indentation of 4 spaces for my {
"vsicons.presets.angular": false,
"editor.tabSize": 2,
"editor.detectIndentation": false,
"editor.formatOnSave": false
} Added the same for my // Place your settings in this file to overwrite the default settings
{
"editor.tabSize": 2,
"editor.detectIndentation": false,
"editor.formatOnSave": false,
"typescript.check.tscVersion": false,
"window.zoomLevel": 0,
"files.trimTrailingWhitespace": true,
"npm.validate.enable": false,
"editor.minimap.enabled": true,
"workbench.iconTheme": "vscode-icons",
"[javascript]": {
"editor.tabSize": 2
}
} Still it auto-indents on every save to 4 spaces! Is there any way to get around this on the current release? Or is it some extension playing tricks on me? |
@kristianmandrup You can try disabling all extensions, with vanilla VS Code, do following
Above user settings will have tab size to 2 for all files. To do just for javascript files have following in user settings
Let me know if above works for you? |
This is exactly what I tried (see above), except disabling all my extensions. Thanks anyways. |
can you try disabling extensions and see if it works? |
Turned out the vscode-JS-CSS-HTML-formatter extension was to blame. Solved now! Thanks |
I just encountered the same trap, and @kristianmandrup is right.
|
@sandy081 - the editor.detectIndentation trick worked for me. Thanks! |
Following settings are not getting update by language
The text was updated successfully, but these errors were encountered: