Code Insider complains "Could not install typings files for JS/TS language features. Please ensure that NPM is installed" #24961

HungryJake · 2017-04-18T16:45:15Z

VSCode Version: Insider (daily latest, 1.12.0)
OS Version: Mac OS X 10.12.4

Steps to Reproduce:

I've nvm, node, and npm installed the current version in the system.
Open Code Insider
Open any existing JavaScript (ES) node project, warning appears:
"Could not install typings files for JS/TS language features. Please ensure that NPM is installed"

mjbvz · 2017-04-18T17:35:04Z

Can you please share the output from running:

$ which npm
$ npm --version

in your terminal

TheSisb · 2017-04-19T00:36:39Z

Same error

➜  ~ which npm
/usr/local/bin/npm
➜  ~ npm --version
4.0.5

That said, I don't use TS. The error led me here.

mjbvz · 2017-04-19T01:04:28Z

TypeScript powers both our JavaScript and TypeScript language features.

To diagnose this, can you please try collecting the tsserver log:

Set "typescript.tsserver.log": "verbose",
Restart VSCode and reproduce the issue
Run the TypeScript: Open TS Server log file command and share the log file
Also reveal the location of the log file in the finder. There should be a ti-xxx.log file next to it with information about typings install

⚠️Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this

wprater · 2017-04-19T21:05:54Z

having the same issue with code-insiders and n node manager.

however, I think its related to this issue #10876 and if I open from the CLI, the issue does not persist.

mjbvz · 2017-04-20T06:34:47Z

I've opened microsoft/TypeScript#15287 to track typings install issues when using n/nvm. If you run into this, as a workaround, try fully restarting VSCode. If you are running from the command prompt, also restart that. This should ensure that VSCode is using the current PATH. (#23649 tracks re-reading the environment for each new VSCode window)

@DrkCoater / TheSisb Are you using n or nvm? Can you also try restarting VSCode fully to see if you are also running into a PATH issue

HungryJake · 2017-04-20T17:14:53Z

My npm is in path actually, although I'm also using nvm. I have already restarted my machine as well as Code fully serval times. The warning still coming up. I think it only happened since an update some time last week, it didn't happen before. thanks

which npm:
~/.nvm/versions/node/v7.8.0/bin/npm
npm --version
4.2.0

HungryJake · 2017-04-20T17:27:37Z

And I found this related log message from the tsserver.log according to your procedures:

Info 29 Received response: {"kind":"event::initializationFailed","message":"Command failed: npm install types-registry"}
Info 30 event: {"seq":0,"type":"event","event":"typesInstallerInitializationFailed","body":{"message":"Command failed: npm install types-registry"}}

mjbvz · 2017-04-24T23:27:42Z

Yes, we added this warning message recently to catch cases just like this. When typescript cannot find npm, automatic typing acquisition will not work. #25112 added a way to disable this warning if it is getting in the way.

@DrkCoater Can you open the developer console (Help -> Toggle Developer Tools) and evaluate process.env['PATH'] in the console. I suspect that nvm's path is not in there.

If this is the case, try running code from the command line to ensure the proper PATH is picked up. #15452 and #23649 both track ensuring that we load the proper environment when launching VSCode

mjbvz · 2017-04-24T23:30:17Z

@joaomoreno Any thoughts on ensuring we pick up the PATH from a user's .bashrc?

joaomoreno · 2017-04-25T07:28:41Z

We already do it.

@DrkCoater says

I think it only happened since an update some time last week, it didn't happen before.

And I agree with him. This already happened to me twice, and only after an update. So it has something to do with how Squirrel reinitialises the app once updated. For sure it didn't happen before lazyEnv was introduced. cc @jrieken

jrieken · 2017-04-25T07:39:23Z

For sure it didn't happen before lazyEnv was introduced. cc @jrieken

What make you so sure about that? The only thing we do while lazyEnv is working is loading code, the extension host gets its environment only when being started

joaomoreno · 2017-04-25T07:41:22Z

A feeling. It could also be a coincidence that this message appeared at around roughly the same time.

HungryJake · 2017-04-25T16:39:30Z

@mjbvz FYI, for process.env['PATH'], my path is actually there:
/.../bin:/.../.nvm/versions/node/v7.8.0/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin
my node executable is at: /.../.nvm/versions/node/v7.8.0/bin

wprater · 2017-04-26T07:09:59Z

And I agree with him. This already happened to me twice, and only after an update. So it has something to do with how Squirrel reinitialises the app once updated. For sure it didn't happen before lazyEnv was introduced. cc @jrieken

Even after an update, if I quite and re-open the app normally the issues persists. If I open from the CLI, then it will go away and my PATH is correct.

chrmarti · 2017-04-26T17:46:50Z

VSCode Version: Code - Insiders 1.12.0-insider (48ae6e3, 2017-04-26T06:32:53.505Z)
OS Version: Linux x64 3.13.0-108-generic
Extensions: none

This reproduces after each start from the dock on Ubuntu. ATA still works afterwards, probably from the existing .d.ts cache. process.env['PATH'] is missing n's path that is added in .bashrc.

The reason for this is process.env['VSCODE_CLI'] being set, which makes shellEnv.ts skip getUnixShellEnvironment(). I don't see why that is set though. When I open a (non-VSCode) terminal VSCODE_CLI is not set.

jrieken · 2017-04-27T06:05:51Z

The reason for this is process.env['VSCODE_CLI'] being set,

Whooot 😱

chrmarti · 2017-04-27T15:23:00Z

@joaomoreno @jrieken @Tyriar Any idea why process.env['VSCODE_CLI'] might be set on my when starting from the dock in Ubuntu? ATA not working will be annoying to JavaScript users.

jrieken · 2017-04-27T15:41:08Z

This should only be set when launching via scripts/code.[sh|bat]. I see a reference in cli.ts of which @joaomoreno might know more?

joaomoreno · 2017-04-27T15:45:56Z

I have no clue. Something must be setting it in your system... Weird.

Tyriar · 2017-04-27T16:40:10Z

VSCODE_CLI is set for the window when it's launched from the CLI https://github.com/Microsoft/vscode/blob/c5df2b09b339868e3ae1dcec907fa793a14bc79e/src/vs/code/node/cli.ts#L42, ie. retain the shell environment.

I accepted a pull request this iteration that changed the desktop entry to launch through the CLI: #24523, #10091

So reading through these issues it looks like here is what is going on:

VirtualBox: VSCode showing an empty window after installation on Ubuntu #10091 bin/ was added to the desktop entry to support people who started something like fish/tmux in their .bashrc which breaks vscode.
Code Insider complains "Could not install typings files for JS/TS language features. Please ensure that NPM is installed" #24961 (this issue) has a path that's needed by ATA set up in .bashrc.

The obvious fix here is to move the ATA PATH setup to .bash_profile which is run when logging in for Linux. Thoughts?

mjbvz · 2017-04-27T16:53:42Z

We don't do anything specific to set up ATA. All we need is a PATH that has npm somewhere.

On my Mac and Ubuntu test machines at least, nvm only added itself to the ~/.bashrc and not to the ~/.bash_profile

bernljung · 2017-08-31T16:42:00Z

@chrmarti I'm not running as root, in fact OS X Sierra makes it hard to even edit /usr/bin and the likes due to System Integrity Protection...

Permissions are 755 with root:wheel as owner.

chrmarti · 2017-08-31T17:44:41Z

@bernljung Your previous comment says /usr/sbin which is usually only used by root. Was that a typo? How did you install npm there?

bernljung · 2017-08-31T19:46:20Z

I've tried both. Npm is installed in /usr/local/bin/npm and then symlinked to /usr/bin/npm and /usr/sbin/npm. (for VSC testing only)

viktor-wolf · 2017-09-08T19:45:07Z

I'm still getting this issue on v1.16 running on Antergos.
Running which npm in the integrated terminal outputs: /home/viktor/.nvm/versions/node/v8.4.0/bin/npm. I have set my typescript.npm setting to this path, but it didn't fix the issue. I have also tried running VS Code from bash, but it didn't help.
Here is my ti log file (I changed the extension to txt, because GitHub doesn't support upload for .log): ti-6028.txt

mjbvz · 2017-09-08T21:52:02Z

Thanks @viktor-wolf! I've opened microsoft/TypeScript#18344 to track this failure. Can you please try running "/home/viktor/.nvm/versions/node/v8.4.0/bin/npm" install --ignore-scripts types-registry on the command line and posting the output to the new issue

nickytonline · 2017-09-13T14:47:22Z

The only way I can get this to work is by launching VS Code via the command line, https://code.visualstudio.com/docs/setup/mac. If I open it from the Dock on OS X, it always gives this error, even when adding "typescript.npm": "/usr/local/bin/npm"

viktor-wolf · 2017-09-17T08:24:20Z

@nickytonline Thanks for the tip. I tried launching Code from CLI and it didn't show the error. After that initial CLI launch I no longer get it even when I launch from a shortcut. However, I'm not sure if the underlying problem got fixed, since I still have the types-registry error in my ts log.

nickytonline · 2017-09-18T00:49:39Z

@viktor-wolf, I'll check my logs when I have a chance to see if it still persisted.

viktor-wolf · 2017-09-26T17:38:15Z

Actually, disregard my previous comment. I just went to change some preferences and I noticed that the typescript check was disabled ("typescript.check.npmIsInstalled": false). I must have misclicked on the "Don't check again" option at some point without noticing. After removing this setting I started getting the warning again, whether I run Code from terminal or not.

rhzs · 2017-10-05T17:02:41Z

Still have the problem with new version 1.16.1

What should I do? @mjbvz

$ /Users/angel/.nvm/versions/node/v8.5.0/bin/npm  install --ignore-scripts types-registry
npm ERR! path /Users/angel/abx/node_modules/.staging/types-registry-38e9fd4a/
npm ERR! code EISDIR
npm ERR! errno -21
npm ERR! syscall open
npm ERR! EISDIR: illegal operation on a directory, open '/Users/angel/abx/node_modules/.staging/types-registry-38e9fd4a/'

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/angel/.npm/_logs/2017-10-05T16_57_51_693Z-debug.log

Spown · 2017-10-05T17:23:10Z

I've just updated tsc from 2.5.2 to 2.5.3 ~~and the warning seems gone now...~~

tgreen7 · 2017-10-05T17:25:00Z

I upgraded typescript to 2.5.3 and am still seeing this.

Spown · 2017-10-05T17:26:30Z

~~I also moved npm higher (to the left) in the PATH var. maybe it did the trick...~~ seeing it again. wierd. I restarted VSC trice and only the third time I got this message again.

VinceOPS · 2017-10-05T17:28:58Z

Having the issue too, VSCode 1.6.1, npm 4.6.1, typescript 2.5.3, running on Debian.

Spown · 2017-10-05T17:38:11Z

and its gone again. just restarted VSC like 8 times. my guess is it sends a request to the typings repository. and probably because of the load gets no/error response. shows a wrong error though.

bepvte · 2017-10-05T17:42:01Z

I temporarily solved it by running sudo npm install -g types-registry

kylejw1 · 2017-10-05T17:44:26Z

I just ran into this issue. I also had an issue running:
npm install -g --ignore-scripts types-registry

I created the .staging directory manually, then the npm install was successful and the message went away:
mkdir -p ~/.nvm/versions/node/v8.6.0/lib/node_modules/.staging

Version 1.17.0-insider
f6ef4be

SharakPL · 2017-10-05T17:50:10Z

Could not install typings files for JavaScript language features. Please ensure that NPM is installed or configure 'typescript.npm' in your user settings

I've just got this warning on my VSCode (1.16.1 updated few weeks ago) after updating npm from 5.4.2 to 5.5.1 with npm update -g. My settings are default (i think):

"typescript.npm": null,
"typescript.check.npmIsInstalled": true,

SharakPL · 2017-10-05T18:17:10Z

Got back to npm 5.4.2 with npm install -g npm@latest and warning stopped showing up :)

bojand · 2017-10-05T18:26:25Z

Started getting this as well with the stock node 8.6.0 and stock npm 5.3.0 installed via the Node.js installer.

In TS Server log:

Info 34   [15:4:27.228] Received response: {"kind":"event::initializationFailed","message":"Command failed: npm install --ignore-scripts types-registry"}
Info 35   [15:4:27.228] event: {"seq":0,"type":"event","event":"typesInstallerInitializationFailed","body":{"message":"Command failed: npm install --ignore-scripts types-registry"}}

Of important note is that we use internal npm registry at work (not sure what's the provider, but it's not NPM Inc.) so my ~/.npmrc:

; My private settings for public npm
;//registry.npmjs.org/:{auth stuff}

; Work settings
registry=http://{internal corp npm repo}
_auth={auth info}
email={email}

When I use the public one VSCode works fine. When I comment out the public one and use the internal one I get the error. This used to work without issues forever, so not sure what happened all of a sudden to cause it. It seems types-registry package was updated 48 minutes ago. So it may be a case where the mirror is lagging behind in getting it / syncing with the public npm. I will keep an eye on this and see if it goes away out of the blue, which may indicate this is the issue. Just posting so others may be aware that this could be the cause if they're using a private mirror or some similar setup.

[EDIT] Update. The error went away after a little while as our mirror picked up the new types-registry

jasonpolites · 2017-10-17T17:06:42Z

Any idea why this issue is closed? I get the same error on a fresh install of VSC. I'm using nvm via linux subsystem (Ubuntu) on Win 10

mjbvz · 2017-10-17T17:42:18Z

@jasonpolites Please open a new issue if you don't see this working. Also, have you looked through the documentation on this: https://code.visualstudio.com/Docs/languages/javascript#_fixing-npm-not-installed-warning-for-automatic-type-acquisition

jasonpolites · 2017-10-17T18:38:57Z

I will open a new issue as I've run out of things to try (including the aforementioned docs). Thanks!

Ashleycodesseo · 2017-11-08T20:40:29Z

I'm also getting this error message. Can anyone give instructions in plain english how to fix this?

mjbvz · 2017-11-08T20:51:03Z

Locking this issue. Please see our documentation on solving this problem.

If you still have problems after following the steps in the docs, please open a new issue

Fixes microsoft#24961

mjbvz self-assigned this Apr 18, 2017

mjbvz added javascript JavaScript support issues typescript Typescript support issues info-needed Issue requires more information from poster labels Apr 18, 2017

mjbvz removed the info-needed Issue requires more information from poster label Apr 20, 2017

mjbvz added the bug Issue identified by VS Code Team member as probable bug label Apr 20, 2017

chrmarti assigned joaomoreno Apr 26, 2017

Tyriar self-assigned this Apr 27, 2017

Tyriar added this to the April 2017 milestone Apr 27, 2017

mjbvz mentioned this issue Sep 8, 2017

npm install types-registry: Command failed microsoft/TypeScript#18344

Closed

wprater mentioned this issue Oct 13, 2017

PATH issues with Fish shell on macOS #21655

Closed

jasonpolites mentioned this issue Oct 17, 2017

Could not install typings files for JavaScript language features. Please ensure that NPM is installed or configure 'typescript.npm' in your user settings (again) #36444

Closed

microsoft locked and limited conversation to collaborators Nov 8, 2017

lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022

Don't use the CLI for the desktop entry

96b1dcb

Fixes microsoft#24961

Code Insider complains "Could not install typings files for JS/TS language features. Please ensure that NPM is installed" #24961

Code Insider complains "Could not install typings files for JS/TS language features. Please ensure that NPM is installed" #24961

Comments

HungryJake commented Apr 18, 2017

mjbvz commented Apr 18, 2017

TheSisb commented Apr 19, 2017 • edited

mjbvz commented Apr 19, 2017

wprater commented Apr 19, 2017 • edited

mjbvz commented Apr 20, 2017

HungryJake commented Apr 20, 2017 • edited

HungryJake commented Apr 20, 2017 • edited

mjbvz commented Apr 24, 2017

mjbvz commented Apr 24, 2017

joaomoreno commented Apr 25, 2017 • edited

jrieken commented Apr 25, 2017

joaomoreno commented Apr 25, 2017

HungryJake commented Apr 25, 2017

wprater commented Apr 26, 2017

chrmarti commented Apr 26, 2017

jrieken commented Apr 27, 2017

chrmarti commented Apr 27, 2017

jrieken commented Apr 27, 2017

joaomoreno commented Apr 27, 2017

Tyriar commented Apr 27, 2017

mjbvz commented Apr 27, 2017 • edited

bernljung commented Aug 31, 2017

chrmarti commented Aug 31, 2017

bernljung commented Aug 31, 2017

viktor-wolf commented Sep 8, 2017 • edited

mjbvz commented Sep 8, 2017

nickytonline commented Sep 13, 2017

viktor-wolf commented Sep 17, 2017

nickytonline commented Sep 18, 2017

viktor-wolf commented Sep 26, 2017 • edited

rhzs commented Oct 5, 2017

Spown commented Oct 5, 2017 • edited

tgreen7 commented Oct 5, 2017

Spown commented Oct 5, 2017 • edited

VinceOPS commented Oct 5, 2017

Spown commented Oct 5, 2017

bepvte commented Oct 5, 2017

kylejw1 commented Oct 5, 2017 • edited

SharakPL commented Oct 5, 2017

SharakPL commented Oct 5, 2017

bojand commented Oct 5, 2017 • edited

jasonpolites commented Oct 17, 2017

mjbvz commented Oct 17, 2017

jasonpolites commented Oct 17, 2017

Ashleycodesseo commented Nov 8, 2017

mjbvz commented Nov 8, 2017 • edited

TheSisb commented Apr 19, 2017 •

edited

wprater commented Apr 19, 2017 •

edited

HungryJake commented Apr 20, 2017 •

edited

HungryJake commented Apr 20, 2017 •

edited

joaomoreno commented Apr 25, 2017 •

edited

mjbvz commented Apr 27, 2017 •

edited

viktor-wolf commented Sep 8, 2017 •

edited

viktor-wolf commented Sep 26, 2017 •

edited

Spown commented Oct 5, 2017 •

edited

Spown commented Oct 5, 2017 •

edited

kylejw1 commented Oct 5, 2017 •

edited

bojand commented Oct 5, 2017 •

edited

mjbvz commented Nov 8, 2017 •

edited