Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to open context menus using touch gesture #30147

Closed
penproductions opened this issue Jul 5, 2017 · 3 comments
Closed

Allow to open context menus using touch gesture #30147

penproductions opened this issue Jul 5, 2017 · 3 comments
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities tree-widget Tree widget issues
Milestone
Backlog

Comments

@penproductions
Copy link

penproductions commented Jul 5, 2017 •
edited
Loading

  • VSCode Version: 1.13.1
  • OS Version: Windows 10
  • System: Surface Pro 4

Steps to Reproduce:

  1. Click and hold with your finger on a file in the explorer pane
  2. A square box appears under your finger but no menu is created.

Press and hold with your finger should be the same as a right click with a mouse.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the workbench label Jul 5, 2017
@bpasero bpasero changed the title Click hold with touch in explorer pane doesn't open menu Allow to open context menus using touch gesture Jul 6, 2017
@bpasero bpasero added the feature-request Request for new features or functionality label Jul 6, 2017
@bpasero bpasero removed their assignment Jul 6, 2017
@bpasero
Copy link
Member

bpasero commented Oct 23, 2017

@joaomoreno is there any reason the tree/list widget is not listening to Touch.EventType.Contextmenu to forward this to the onShowContextMenu handlers?

It seems both widgets receive this event via the Gesture helper (here and here).

@joaomoreno joaomoreno added this to the Backlog milestone Oct 27, 2017
@joaomoreno joaomoreno removed their assignment Oct 27, 2017
@joaomoreno joaomoreno added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Oct 27, 2017
@bpasero bpasero added tree-widget Tree widget issues and removed workbench labels Nov 16, 2017
@romainlq
Copy link

VSCode Version: 1.20.1
OS Version: Windows 10
System: Dell Inspiron

Is this still on ? I'm actually getting the context menu when I press & hold on a file

Reproduces without extensions: Yes

@oriash93
Copy link
Contributor

VSCode Version: 1.21.1
OS Version: Windows 10
System: ASUS VivoBook Flip

I'm getting the context menu too.

Reproduces without extensions: Yes

@bpasero bpasero closed this as completed Mar 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities tree-widget Tree widget issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@joaomoreno @bpasero @romainlq @oriash93 @penproductions