Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown references links don't handle escapes #35245

Closed
mjbvz opened this issue Sep 27, 2017 · 2 comments · Fixed by #75357
Closed

Markdown references links don't handle escapes #35245

mjbvz opened this issue Sep 27, 2017 · 2 comments · Fixed by #75357
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities markdown Markdown support issues verified Verification succeeded
Milestone
June 2019

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 27, 2017 •
edited
Loading

From #33714 (comment)

In a markdown file:

text [more info][aut\]osave] text

[aut\]osave]: /docs/editor/codebasics.md#saveauto-save

Does not detect aut\]osave as a link
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Sep 27, 2017
@mjbvz mjbvz self-assigned this Sep 27, 2017
@mjbvz mjbvz mentioned this issue Sep 27, 2017
Closed
@Liam-Newell
Copy link

Liam-Newell commented Feb 15, 2018 •
edited
Loading

Did you mean auto]save? @mjbvz #35245

@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Feb 5, 2019
@mjbvz mjbvz added the good first issue Issues identified as good for first-time contributors label May 18, 2019
@Olovan
Copy link
Contributor

Olovan commented Jun 12, 2019

Added a merge request with some tweaks to the regex that is used to detect links. With the fix it should now correctly detect links with "]" in their names.

@Olovan Olovan mentioned this issue Jun 12, 2019
Merged
@mjbvz mjbvz added this to the June 2019 milestone Jun 12, 2019
mjbvz added a commit that referenced this issue Jun 12, 2019
@mjbvz
Merge pull request #75357 from Olovan/fix_35245
2ad085b 
Fix for issue #35245
@lramos15 lramos15 added the verified Verification succeeded label Jun 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
June 2019
Development

Successfully merging a pull request may close this issue.

Fix for issue #35245
4 participants
@Liam-Newell @lramos15 @mjbvz @Olovan