Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match whole word does not work for not latin characters (at least for cyrillic) #3623

Closed
KvanTTT opened this issue Mar 2, 2016 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations verified Verification succeeded
Milestone

Comments

@KvanTTT
Copy link

KvanTTT commented Mar 2, 2016

I created the next document:

я
компилятор
обфускация

i
compiler
cli

And if I am trying to find all whole words "я", vscode highlights all three first words. But if I am trying to find "i", vs code highlights only fourth word.

@nixel2007
Copy link

@alexandrudima link to code -
https://github.com/Microsoft/vscode/blob/fb5b68d199918fbe58e57d4faa3909580430fa4e/src/vs/base/common/strings.ts#L184

The problem is in \b - it doesn't support non-en symbols

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label May 23, 2016
@alexdima alexdima added the editor-find Editor find operations label Jun 26, 2016
@ebugusey
Copy link

The problem is that js doesn't have full support for unicode. Even with /u in ES6 it just doesn't work. You should use oniguruma for regular expressions, like Atom does.

@nixel2007
Copy link

@ebugusey atom does not use oniguruma everywhere or it doesn't help in all cases. I've made a unicode support for Atom-autocomplete using the XRegExp library.

@martinsuchan
Copy link

Just discovered this bug - still happening in VS Code 1.9. It's especially problematic when searching for specific word in localized comments or searching for all usages of variable with short name:
match_whole_word

@alexdima alexdima added this to the Backlog milestone Feb 28, 2017
@alexdima alexdima modified the milestones: May 2017, Backlog May 20, 2017
@alexdima
Copy link
Member

fyi @roblourens

@bambr1975
Copy link

bambr1975 commented May 25, 2017

default
Doesn't work

@alexdima
Copy link
Member

Search in files uses a different implementation. Hence the ping to @roblourens

@roblourens
Copy link
Member

Opened a new issue for it, #27280

@michelkaporin michelkaporin added the verified Verification succeeded label Jun 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
IllusionMH added a commit to IllusionMH/vscode that referenced this issue Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants