Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the deb installing keys and repositories on my system without permission? #39544

Closed
hamid-elaosta opened this issue Dec 4, 2017 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) install-update VS Code installation and upgrade system issues

Comments

@hamid-elaosta
Copy link

Steps to Reproduce:

  1. Install VsCode .deb 1.10
  2. Check apt-key list, find Microsoft key in trusted list
  3. Check /etc/apt/sources.list.d/ find vscode.list in directory

Having the software stay up to date is great, and I would likely install the repository manually, but, the audacity to add a repo to my apt lists and a trusted key without my permission, or any indication that it has been done is utterly abhorrent.

I suggest a prompt for permission to add such key and repository is presented to the user, as the current method is an abuse. I have no ability to install the deb without providing root/sudo permission, and hi-jacking that permission to also add these to my system without permission or notification is exactly the underhanded behavior I expect from Microsoft products.

@vscodebot vscodebot bot added the install-update VS Code installation and upgrade system issues label Dec 4, 2017
@hamid-elaosta
Copy link
Author

Just to add context; The key/repo is installed to facilitate automatic updates more easily without the user needing to add these manually.

This "feature" is not in question here.

VSCode is targeted towards developers not general public, and so security should be given more consideration.

@Tyriar
Copy link
Member

Tyriar commented Dec 11, 2017

We plan on fixing this by bringing in support for snap packages #5458 in the next couple of months as auto-updating will then be handled by the Snapcraft Store. In the meantime you can use the tarball if the current deb package is a concern.

There's also an issue to allow opting out of the key/repo install via an environment variable here #22145 (closing as duplicate of that)

@Tyriar Tyriar closed this as completed Dec 11, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 11, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) install-update VS Code installation and upgrade system issues
Projects
None yet
Development

No branches or pull requests

2 participants