Workbench doesn't finish loading when Extensions viewlet is first to load

[joaomoreno]

Windows

1. In Dev, have no extensions in the extensions folder
2. Open the Extensions viewlet
3. Close Code
4. Open it again .\scripts\code

[bpasero]

Weird, I cannot reproduce :-/

[bpasero]

@sandy081 any chance some call on the restore of the extensions viewlet waits on the extension service to be ready?

[sandy081]

@bpasero Extensions viewlet has no dependency on extensions ready promise.

[bpasero]

I can reproduce, but only on Windows and only when running out of dev.

[sandy081]

But, I think the ViewsViewlet uses extensions ready promise.. but it is not a blocking one though

[bpasero]

@sandy081 it looks like the call to this.extensionManagementService.getInstalled is deadlocking:

@alexandrudima could this be a regression from your changes to cache the contents?

Btw this is not reproducible all the time, when I break before this call and then jump over it does not reproduce. So maybe something that spawns in the back has a chance to then come up because of debugging.

[sandy081]

@bpasero 👍

[alexdima]

@bpasero I don't believe so. The caching I implemented is not in the IExtensionManagementService (service managing extensions). I implemented caching in IExtensionService (service running extensions). Moreover, caching code is not executing when running from dev.

[sandy081]

Right. Getting installed extensions from extension management service is not using any caching. It just reads folders from the disk.

I will try to reproduce it in Windows and investigate.

[bpasero]

@alexandrudima @joaomoreno this is a regression from b712555

The extension viewlet create method needs the shared process and probably at that time the shared process is not ready, but I am not sure why that would not eventually resolve itself for good.

[alexdima]

Thank you @bpasero for tracking it down.

@joaomoreno Help! This timeout is causing so much grief! And I'm not sure it is 100% working. I think I've seen the process start after 3s, not after 5s.

[alexdima]

Ok. I am reverting the timeout.

@bpasero @joaomoreno Do you think this should go on the stable channel too ?

[alexdima]

Reverted via 4e3205f

[alexdima]

Opened #40505 to track that we delay the start-up of the shared process.

[bpasero]

@alexandrudima thanks. I thought about stable but actually this will never be executed in stable because only when running out of sources we actually restore the last used viewlet. For stable and insiders when you start fresh we always open the explorer viewlet. The only time we actually open the extension viewlet is when you reload the window, but then chances are high that the shared process has started already. I think it is unlikely to hit this unless maybe you manage to start Code, open extensions viewlet and reload the window, all under 3-5 seconds.