Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A narrow gap occurs between code map and scrollbar #42183

Closed
XieJiSS opened this issue Jan 26, 2018 · 7 comments
Closed

A narrow gap occurs between code map and scrollbar #42183

XieJiSS opened this issue Jan 26, 2018 · 7 comments
Assignees
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues zoom VS Code window zoom issues
Milestone

Comments

@XieJiSS
Copy link

XieJiSS commented Jan 26, 2018

  • VSCode Version: 1.19.3
  • OS Version: Windows 10 x64 1511

This seems to be a layout bug.

Steps to Reproduce:

  1. Find a 1920*1080 screen
  2. Open VSCode
  3. Use win+leftArrow to move VSCode to the left part of the screen

You can see a narrow gap between the code map and the scrollbar.

scr 18-01-26 13-16-33

bandicam-2018-01-26-13-26-15-168

Does this issue occur when all extensions are disabled?: Yes

I disabled all my extensions and still, it occurs:

image

@vscodebot vscodebot bot added editor editor-core Editor basic functionality labels Jan 26, 2018
@XieJiSS
Copy link
Author

XieJiSS commented Jan 26, 2018

And if I change the width of the VSCode editor, this bug might disappear.
Also, this bug occurs when window_width=880 (using Snipaste to find out)
image

@XieJiSS
Copy link
Author

XieJiSS commented Jan 26, 2018

Well, actually my OS version is Windows 10 x64 1511 10586.104

@XieJiSS XieJiSS changed the title A narrow gap between code map and scrollbar A narrow gap occurs between code map and scrollbar Jan 26, 2018
@alexdima alexdima added windows VS Code on Windows issues editor-rendering Editor rendering issues and removed editor editor-core Editor basic functionality labels Jan 29, 2018
@XieJiSS
Copy link
Author

XieJiSS commented Jan 29, 2018

scr 18-01-29 21-49-54

updated my os to Windows 10 x64 1709 16299.125, the same error still occurs.

@alexdima
Copy link
Member

@jiejiss

I've seen this issue before -- #34974 , but I could never reproduce.

  • Are you using some form of zoomLevel in your settings ?

  • I've pushed a small tweak in how the minimap is positioned recently. This tweak is in the Insiders Release. Can you please try to see if the insiders version still produces this -- https://code.visualstudio.com/insiders/

@XieJiSS
Copy link
Author

XieJiSS commented Jan 29, 2018

@alexandrudima You're right. I found window.zoomLevel: 1 in my settings.json, and after I removed it, I cannot reproduce this bug either.
I'm sorry to say that now I'm in China(UTC+0800) and it is 11:58 here so maybe I'll have to try the insider version tomorrow.
thanks very much!

@XieJiSS
Copy link
Author

XieJiSS commented Jan 30, 2018

@alexandrudima Tested on insider version.

Ummm, the patch sometimes works.
If I resize the window by dragging the edge slowly, sometimes I can see the narrow gap. But if I resize the window with Win+←, then everything's right.
What's more, if I manage to produce a gap by dragging the edge (after I have moved the window to the left of the screen with Win+←) and I press the Win+↑ to move it to the upper-left, then the gap disappear (even if I didn't change the width of the window).

btw, I found another 1px gap this time (at the bottom of the code map):

scr 18-01-30 22-38-22

@alexdima alexdima added zoom VS Code window zoom issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed editor-rendering Editor rendering issues labels Feb 1, 2018
@alexdima alexdima added this to the Backlog milestone Feb 1, 2018
@XieJiSS
Copy link
Author

XieJiSS commented Feb 2, 2018

Well, feel free to close this issue.
At least I can get rid of it by changing the value of window.zoomLevel to 0
@alexandrudima thanks a lot!

@alexdima alexdima closed this as completed Feb 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues zoom VS Code window zoom issues
Projects
None yet
Development

No branches or pull requests

2 participants