ps-win.ps1 errors when running code --status

[Tyriar]

Extracted from #43169 (comment)

Collecting CPU and memory information. This might take a couple of seconds.
[main 3:39:47 PM] Error: Get-WmiObject : Invalid class "Win32_Process"
At C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\base\node\ps-win.ps1:114 char:19
+ foreach ($item in Get-WmiObject Win32_Process -Filter "name = '$ProcessName'") {
+                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidType: (:) [Get-WmiObject], ManagementException
    + FullyQualifiedErrorId : GetWMIManagementException,Microsoft.PowerShell.Commands.GetWmiObjectCom
   mand

Get-WmiObject : Invalid class "Win32_Process"
At C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\base\node\ps-win.ps1:117 char:19
+ foreach ($item in Get-WmiObject Win32_Process -Filter "name = 'codeHelper.exe'") ...
+                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidType: (:) [Get-WmiObject], ManagementException
    + FullyQualifiedErrorId : GetWMIManagementException,Microsoft.PowerShell.Commands.GetWmiObjectCom
   mand

Get-WmiObject : Invalid class "Win32_Process"
At C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\base\node\ps-win.ps1:121 char:19
+ foreach ($item in Get-WmiObject Win32_Process -Filter "name Like '%'") {
+                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidType: (:) [Get-WmiObject], ManagementException
    + FullyQualifiedErrorId : GetWMIManagementException,Microsoft.PowerShell.Commands.GetWmiObjectCom
   mand


    at ChildProcess.<anonymous> (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main
\main.js:157:375)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:194:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)

It might make sense to transition to windows-process-tree v0.2.0 instead of fixing this. /cc @RMacfarlane

[dbaeumer]

@RMacfarlane does windows-process-tree offer CPU information as well ?

[Tyriar]

@dbaeumer it does as of about a week ago, you'll want to use these calls https://github.com/Microsoft/vscode-windows-process-tree/blob/bf4a0a2d2edf30acf7f2d856b0ed876a11475f23/typings/windows-process-tree.d.ts#L49-L62

[RMacfarlane]

@dbaeumer @Tyriar I also have #46433 tracking this as I want to reuse this same code path in the process explorer. I went ahead and made a PR for the change, @dbaeumer it would be great if you could take a look: #47152

The only issue I've run into with the windows-process-tree module so far is that the length limit on the commandLine property, 512 chars, sometimes results in the ends of arguments getting cut off for extHost processes. This throws off matching to calculate a better display name:

microsoft/vscode-windows-process-tree#23 is tracking that

[dbaeumer]

@RMacfarlane thanks a lot for providing the PR. I will have a look!

[RMacfarlane]

I updated the windows-process-tree module to have a length limit of 4096 for commandLine, have now merged in the changes to use it when listing processes, 6b62365

[dbaeumer]

@RMacfarlane +1 for merging that in.