Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase commandLine length limit #23

Closed
RMacfarlane opened this issue Apr 3, 2018 · 3 comments
Closed

Increase commandLine length limit #23

RMacfarlane opened this issue Apr 3, 2018 · 3 comments
Assignees

Comments

@RMacfarlane
Copy link
Contributor

The current limit, 512 characters, is rather low. See if there is a way to increase this limit

@Tyriar
Copy link
Member

Tyriar commented Apr 3, 2018

Maybe we can just up it to 4096? I don't think it's much of a hit if that's too high generally.

@RMacfarlane
Copy link
Contributor Author

The default stack size seems to be 984kb (node --v8-options | grep -A1 stack_size), so to increase it that much, it needs to be run with a higher stack size. Do we do that in VS Code?

I tried changing ProcessInfo process_info[1024] to ProcessInfo* process_info = new ProcessInfo[1024] to allocate on the heap, deleting at the end of HandleOkCallback in the worker, but this causes the "should handle multiple calls gracefully" test to always fail with an access violation error.

One workaround would just be to flip the size of the process_info and commandLine arrays, so that we only read up to 512 processes and read up to 1024 chars of commandLine

@Tyriar
Copy link
Member

Tyriar commented Apr 6, 2018

@RMacfarlane I think I made it that high initially because I was surprised at the amount of processes being returned. Maybe it needs to be done in multiple passes then? Would be good not to compromise on either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants