Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Core language pack support in VS Code #52960

Closed
3 tasks done
sandy081 opened this issue Jun 26, 2018 · 2 comments
Closed
3 tasks done

Test Core language pack support in VS Code #52960

sandy081 opened this issue Jun 26, 2018 · 2 comments

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 26, 2018

Ref: #50588

Complexity: 4

In this release, VS Code is bundled with only english language and other core languages are removed. Please test following scenarios and make sure users are guided properly to install required language packs so that they can have VS Code in the UI language they want.

Core Languages: ['de', 'en', 'en-US', 'es', 'fr', 'it', 'ja', 'ko', 'ru', 'zh-CN', 'zh-TW']

Note: Make sure that prompts are shown in both OS language and English

Note: Latest stable build is here

Fresh Installation

  1. When VS Code is freshly installed on a machine with english language OS its UI is shown in english by default and no prompts to install language packs should be shown.

  2. When VS Code is freshly installed on a machine with non-english language OS (for eg., Chinese) its UI is shown in english by default and user should see a prompt to install the language pack of OS language

  3. When VS Code is freshly installed on a machine and user starts VS Code from CLI by passing locale option code --locale=de then its UI is shown in english by default and user should see a prompt to install the language pack of language passed in arguments (de).

Update

  1. When VS Code is updated from 1.23 or 1.24 to current stable on a machine with OS language is one of the core languages, its UI should be shown in OS language without any prompts if the corresponding language pack has been install on 1.23 or 1.24.

  2. When VS Code is updated from 1.22 or lesser to current stable on a machine with OS language is one of the core languages, its UI should be shown in english language. If OS language is non-english, then user should see a prompt to install the language pack of OS language.

@sandy081 sandy081 added this to the June 2018 milestone Jun 26, 2018
@dbaeumer dbaeumer removed their assignment Jun 26, 2018
@isidorn isidorn assigned joaomoreno, octref and chrmarti and unassigned octref Jun 27, 2018
@joaomoreno joaomoreno removed their assignment Jun 27, 2018
@joaomoreno
Copy link
Member

@sandy081 All great!

@chrmarti
Copy link
Contributor

@joaomoreno Checking your checkbox, maybe that was lost.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants