Prompt for language pack only in English

[chrmarti]

Testing #52960

• VSCode Version: 1.25 build for testing
• OS Version: High Sierra

The test item mentions it should also be in the OS language. That does not seem to be the case.

[ramya-rao-a]

This is because the language pack for French doesn't have the required strings.
For that matter, almost none of the core language packs have the required strings.

@danyeh,
The required translations are in the built-in language support but not in the language pack extensions.

https://github.com/Microsoft/vscode/search?q=installAndRestartMessage&unscoped_q=installAndRestartMessage

https://github.com/Microsoft/vscode-loc/search?q=installAndRestartMessage&unscoped_q=installAndRestartMessage

Can you ensure that these strings get into the language packs?

[sandy081]

@danyeh Following language packs are not missing translations for those necessary strings which we show to user to install the language pack before installing it.

• Necessary translations

showLanguagePackExtensions: localize('showLanguagePackExtensions', "Search language packs in the Marketplace to change the display language to {0}."),
	searchMarketplace: localize('searchMarketplace', "Search Marketplace"),
	installAndRestartMessage: localize('installAndRestartMessage', "Install language pack to change the display language to {0}."),
	installAndRestart: localize('installAndRestart', "Install and Restart")

• de

"vs/platform/node/minimalTranslations": {
	"searchMarketplace": "Marketplace durchsuchen",
	"installAndRestart": "Installieren und neu starten"
}

• es

"vs/platform/node/minimalTranslations": {
    "searchMarketplace": "Buscar en Marketplace ",
    "installAndRestart": "Instalar y Reiniciar"
}

• fr

"vs/platform/node/minimalTranslations": {
    "searchMarketplace": "Rechercher dans le Marketplace",
    "installAndRestart": "Installer et Redémarrer"
}

• it

"vs/platform/node/minimalTranslations": {
    "searchMarketplace": "Cerca nel Marketplace",
    "installAndRestart": "Installa e riavvia"
}

• ja

"vs/platform/node/minimalTranslations": {
    "searchMarketplace": "Marketplace を検索",
    "installAndRestart": "インストールして再起動"
}

• ko

"vs/platform/node/minimalTranslations": {
    "searchMarketplace": "Marketplace 검색",
    "installAndRestart": "설치 및 다시 시작"
}

• ru

"vs/platform/node/minimalTranslations": {
    "searchMarketplace": "Поиск в Marketplace",
    "installAndRestart": "Установить и перезапустить"
}

-zh-tw: No translations at all

Only zh-cn has translations for all strings.

I would request to fix the core language packs and make sure they have necessary translations before we release the stable without core languages.

[ramya-rao-a]

-zh-tw: No translations at all
Only zh-cn has translations for all strings.

@sandy081 When users choose zh-cn or zh-tw we fall back to zh-hans or zh-hant respectively. The pack for zh-hans has the required translations, zh-hant doesnt.

[danyeh]

According to loc schedule, we will cover all strings by end of day July 3rd. And publish language pack afterward.

[sandy081]

When users choose zh-cn or zh-tw we fall back to zh-hans or zh-hant respectively. The pack for zh-hans has the required translations, zh-hant doesnt.

Fallback is only for extension name and locale id contributed by respective extensions still should be zh-cn and zh-tw.

[danyeh]

As of today, we have zh-cn, fr, it, ja, ko language pack loc completed and published in Marketplace.

[sandy081]

Thanks @danyeh for the update.

• zh-cn: This needed fix from our side
  

• fr
  

• it
  

• ja
  

• ko
  

[danyeh]

Remaining language pack loc completed and published in Marketplace - de, es, ru, zh-tw.

[sandy081]

Verified all core language packs showing recommendation prompt in their respective languages.