Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+shift+f shortcut not work in vscode 1.26.1 #57500

Closed
braveheart4217 opened this issue Aug 29, 2018 · 13 comments
Closed

ctrl+shift+f shortcut not work in vscode 1.26.1 #57500

braveheart4217 opened this issue Aug 29, 2018 · 13 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@braveheart4217
Copy link

  • VSCode Version: 1.26.1
  • OS Version: Windows 10

Does this issue occur when all extensions are disabled?: Yes

if i cahnge findInFiles( default: ctrl+shift+f ) to another shortcut, it works

@alexdima
Copy link
Member

What does VS Code detect when you press the desired key combination? Please hover over the input box and take a screenshot:
keyboard-input

@alexdima alexdima added the info-needed Issue requires more information from poster label Aug 29, 2018
@braveheart4217
Copy link
Author

screenshot_1

when i press ctrl + shift + f, vscode shows this

@braveheart4217
Copy link
Author

but when i selected in explorer, ctrl + shift + f works

@alexdima
Copy link
Member

That is bizzare. The received key code is 229 (0xE5) which is VK_PROCESSKEY according to this table

image

I would have expected that you would receive the key code for F, 70 (0x46). Does ctrl+shift+F hold some special meaning under your input mode? What keyboard layout / input mode are you using? Does this reproduce when changing the keyboard layout to English ?

@braveheart4217
Copy link
Author

when i change the keyboard layout to English, it works.
it seems it's the windows chinese input mode calls this problem.

but before i update, everythings is ok, is there something makes it?

finally,thanks you help me fix this annoying problem。

@alexdima
Copy link
Member

@braveheart4217 So this key combination was being interpreted correctly in VSCode 1.25? Here is a download link for a 1.25.1 zip - https://az764295.vo.msecnd.net/stable/1dfc5e557209371715f655691b1235b6b26a06be/VSCode-win32-x64-1.25.1.zip

@pohmelie
Copy link

I have similar issue, but on ubuntu 18.04. After update to 1.26 my ctrl+shift+E stops working, keybinding helper shows ctrl+shift+unknown on ctrl+shift+E pressed. But system key bindings in KDE shows right combination.

@alexdima
Copy link
Member

alexdima commented Aug 30, 2018

@pohmelie IMHO your issue cannot be possibly be related to this issue, as this issue is about Windows, and your issue is about Ubuntu. Those two operating systems have completely different keyboard input handling methods that result in different code paths for both VS Code and Chromium. I'm not sure what your problem could be, but you can open a new issue if you need help.

But bear in mind, we haven't had to do a code change in the keyboard handling code of VS Code since about 1 year. i.e. things always end up being covered by https://github.com/Microsoft/vscode/wiki/Keybinding-Issues or being some weird environmental problem.

@pohmelie
Copy link

@alexandrudima
I agree, that this is probably ubuntu issue, since recently I have updates with "keyboard" word in package name (don't remember package full name). I will test this at home on ubuntu 17.10, it support dropped, so there is already "stable" state for month or greater. Thanks!

@braveheart4217
Copy link
Author

@alexandrudima i have tryed the vscode you just give me, it's the same issue with the 1.26.1,and i have find ctrl+shift+f used in sougou Input(an input app), i closed shortcut in that app, then it works in sougou input, but it still can't work in windows chinese input mode
screenshot_2

@alexdima
Copy link
Member

i have tried the vscode you just give me, it's the same issue with the 1.26.1

This indicates to me that this was not a recent regression from our side.

Are you able in any other software on this machine to get Ctrl+Shift+F to do anything meaningful when you are using the Windows Chinese Input Mode ?

@braveheart4217
Copy link
Author

braveheart4217 commented Aug 31, 2018

oh shit, ctrl+shift+f is the shortcut to switch Simplified or Traditional in Windows Chinese Input Mode

@alexdima
Copy link
Member

👍 That solves the mystery! :)

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants