Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a terminal to be launched with an explicit environment #64731

Closed
GabeDeBacker opened this issue Dec 10, 2018 · 3 comments
Closed

Allow a terminal to be launched with an explicit environment #64731

GabeDeBacker opened this issue Dec 10, 2018 · 3 comments
Assignees
Labels
api-finalization api-proposal feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@GabeDeBacker
Copy link
Contributor

This request is similar to #18522.

VSCode is configuration a bunch of environment variables before the terminal process is launched. For our terminal scenarios (such as setting up our complex build environment) we need to be in complete control of the environment passed in.

In other words, have a flag that tells VSCode to not inherit any of the process environment variables and only use the environment passed in.

In our build environment today, some of the VSCode environment variable values (such as LANG) are not in the proper format when starting the build environment.

We have the ability to specifically set the environment to exactly what we want.

The proposal is adding this:
export interface TerminalOptions {
/**
* When set to true, the process environment from VSCode is ignored and the
* terminal process only contains what is in the "env" member.
*/
noInheritEnv?: boolean;
}

@Tyriar
Copy link
Member

Tyriar commented Dec 10, 2018

Open questions for API call: What's the best name for the setting?

@Tyriar
Copy link
Member

Tyriar commented Jan 19, 2019

Fixed in #64733

@Tyriar Tyriar closed this as completed Jan 19, 2019
@Tyriar Tyriar added the feature-request Request for new features or functionality label Jan 19, 2019
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jan 29, 2019
@Tyriar
Copy link
Member

Tyriar commented Jan 29, 2019

For verification: test the new strictEnv terminal option

@roblourens roblourens added the verified Verification succeeded label Jan 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-finalization api-proposal feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants