Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom theme: line number background color or border #7739

Closed
oryam opened this issue Jun 15, 2016 · 6 comments
Closed

Custom theme: line number background color or border #7739

oryam opened this issue Jun 15, 2016 · 6 comments
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality themes Color theme issues ux User experience issues
Milestone

Comments

@oryam
Copy link

oryam commented Jun 15, 2016

  • VSCode Version: 1.2.1
  • OS Version: Win 7 x64

Steps to Reproduce:

  1. Open a file
  2. Show line numbers in vscode settings ("editor.lineNumbers": true)
  3. Line numbers are shown with a background color same as the background color of the editor area
  4. It makes confusion with indent. We do not know how well the code is indented due to the margin

Suggestion:

  1. Be able to customize the background color of line number area
  2. Make a thin left vertical border along the editor area
@sandy081 sandy081 added the feature-request Request for new features or functionality label Jun 16, 2016
@alexdima alexdima added the ux User experience issues label Jun 16, 2016
@alexdima
Copy link
Member

@oryam We are aware of this problem, we will soon introduce indent guides which help things here, or otherwise I use editor.renderWhitespace which helps in seeing where the text begins.

@oryam
Copy link
Author

oryam commented Jun 16, 2016

Thank you for the tip editor.renderWhitespace.

@bgashler1 bgashler1 added color and removed color labels Jun 21, 2016
@alexdima alexdima added this to the Backlog milestone Aug 9, 2016
@alexdima alexdima added editor-core Editor basic functionality editor labels Aug 31, 2016
@alexdima alexdima removed their assignment Aug 31, 2016
@drinktee
Copy link

I have the same suggestion. I think the width of the line-numbers is a little wide and maybe a waste of space. As the pic shows.
What about /(how to) make it thinner?
image

@alexdima
Copy link
Member

@drinktee The gap is so wide to accommodate both folding indicators and git indicators:

image

@bpasero
Copy link
Member

bpasero commented May 20, 2017

@oryam how about "editorGutter.background" via workbench.colorCustomizations in settings?

Already available from our insiders release: You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

image

@bpasero bpasero added the themes Color theme issues label May 25, 2017
@isidorn
Copy link
Contributor

isidorn commented Nov 20, 2017

If I understand correctlhy @bpasero provided a solution to this, thus closing

@isidorn isidorn closed this as completed Nov 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality themes Color theme issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

7 participants